src: fix creating an ArrayBuffer from a Blob created with openAsBlob#47691
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
daeyeonforce-pushed the main.fix/47683-230424.Mon.d73a branch from 2b97826 to babd5a0Compare
ikreymer commented Apr 24, 2023
Thanks! Assume the fix should also apply to |
Signed-off-by: Daeyeon Jeong <[email protected]>
daeyeonforce-pushed the main.fix/47683-230424.Mon.d73a branch from babd5a0 to 6e40de0Compare
MemberAuthor
daeyeon commented Apr 25, 2023
@ikreymer That would be better. Updated the test for stream also, PTAL. |
ikreymer commented Apr 25, 2023
Yes, that looks good - thanks! |
github-actionsbot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
jasnell approved these changes Apr 26, 2023
35 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
nodejs-github-bot commented Apr 27, 2023
daeyeon added the author ready This was referenced Apr 28, 2023
jasnell pushed a commit that referenced this pull request May 5, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #47691Fixes: #47683 Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented May 5, 2023
Landed in af9b48a |
targos pushed a commit that referenced this pull request May 12, 2023
Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #47691Fixes: #47683 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #47683
This fixes creating an
ArrayBufferfrom a Blob sliced from a Blob created withfs.openAsBlob.Signed-off-by: Daeyeon Jeong [email protected]