src: support V8 experimental shared values in messaging

[syg]

This adds the missing integration support for the V8 experimental shared structs feature (--harmony-struct). There is no observable difference to node if --harmony-struct is not passed. The flag is false by default.

This experimental feature is for proving out shared memory in JS. The standards side is tracked by https://github.com/tc39/proposal-structs, though the current experiment, for the sake of ease of experimentation, does not include syntax. The features in experiment is documented here.

I also intentionally did not add any tests because the features are experimental and volatile. Here is an illustrative example though:

'use strict';const{ Worker, isMainThread, parentPort }=require('worker_threads');if(isMainThread){letBox=newSharedStructType(['payload']);letb=newBox();b.payload="hello shared memory world";letworker=newWorker(__filename);worker.on('message',(message)=>{console.log(b.payload);console.log(message===b);});worker.postMessage(b);}else{parentPort.on('message',(message)=>{// Simple echo.parentPort.postMessage(message);});}

[syg]

cc @rbuckton, I had meant to do this a while back but totally forgot. Once this merges then TSC can start playing around with the dev trial as well.

[debadree25]

cc @nodejs/workers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51470/

[syg]

@joyeecheung I don't know nodejs very well. Is the CI saying this PR is causing some test failures? I find that rather surprising.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51471/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51472/

[joyeecheung]

I don't know nodejs very well. Is the CI saying this PR is causing some test failures? I find that rather surprising.

The test failures were probably just unmarked flakes. https://ci.nodejs.org/job/node-test-pull-request/51472/ passed (with marked flakes).

[addaleax]

I think adding a test would be valuable unless you are really certain that somebody will remember to add one once the feature's no longer experimental :)

[syg]

I think adding a test would be valuable unless you are really certain that somebody will remember to add one once the feature's no longer experimental :)

Reasonable request, though I still prefer to not add a node test. The dev trial API surface is under enough flux that when I change things on the V8 side for the sake of experimentation I don't want to be blocked on breaking nodejs tests on the V8 infra. Whatever test we add now will be highly likely to be invalid once the feature is no longer experimental anyway, because the experimental dev trial doesn't use syntax to declare shared structs.

OTOH I'm all for adding "examples" that aren't run on the CI and block them but can be run by hand. WDYT?

Edit: I added a test.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51606/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51628/

[syg]

@joyeecheung I still don't know how to read the CI reports. :) Does this look good to land?

[syg]

Good to merge?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/51702/

[joyeecheung]

Need to re-run the CI until it's green

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/47706 ✔ Done loading data for nodejs/node/pull/47706 ----------------------------------- PR info ------------------------------------ Title src: support V8 experimental shared values in messaging (#47706) Author Shu-yu Guo (@syg) Branch syg:shared-value-conveyor -> nodejs:main Labels c++, worker, needs-ci Commits 5 - src: support V8 experimental shared values in messaging - Add a test - Fix linter errors - Update test/parallel/test-experimental-shared-value-conveyor.js - Quell linter Committers 2 - Shu-yu Guo - GitHub PR-URL: https://github.com/nodejs/node/pull/47706 Reviewed-By: Joyee Cheung Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47706 Reviewed-By: Joyee Cheung Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 24 Apr 2023 19:05:11 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47706#pullrequestreview-1415757197 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/47706#pullrequestreview-1404880614 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-08T16:44:58Z: https://ci.nodejs.org/job/node-test-pull-request/51702/ - Querying data for job/node-test-pull-request/51702/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47706 From https://github.com/nodejs/node * branch refs/pull/47706/merge -> FETCH_HEAD ✔ Fetched commits as 0b3fcfcf351f..a0946e915825 -------------------------------------------------------------------------------- Auto-merging src/node_messaging.cc [main e400a95a4e] src: support V8 experimental shared values in messaging Author: Shu-yu Guo Date: Mon Apr 24 11:15:07 2023 -0700 2 files changed, 31 insertions(+), 4 deletions(-) [main 620a4f5057] Add a test Author: Shu-yu Guo Date: Tue May 2 13:49:57 2023 -0700 1 file changed, 23 insertions(+) create mode 100644 test/parallel/test-experimental-shared-value-conveyor.js [main 806c2bce27] Fix linter errors Author: Shu-yu Guo Date: Tue May 2 14:14:40 2023 -0700 1 file changed, 2 insertions(+), 2 deletions(-) [main d4b2962cae] Update test/parallel/test-experimental-shared-value-conveyor.js Author: Shu-yu Guo Date: Fri May 5 17:09:16 2023 -0400 1 file changed, 3 insertions(+), 1 deletion(-) [main 641c3af3b9] Quell linter Author: Shu-yu Guo Date: Fri May 5 15:05:18 2023 -0700 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 src: support V8 experimental shared values in messaging
PR-URL: #47706
 Reviewed-By: Joyee Cheung [email protected]
 Reviewed-By: Anna Henningsen [email protected]
[detached HEAD 6a7fbf90f2] src: support V8 experimental shared values in messaging
 Author: Shu-yu Guo [email protected]
 Date: Mon Apr 24 11:15:07 2023 -0700
 2 files changed, 31 insertions(+), 4 deletions(-)
 Rebasing (3/10)
 Rebasing (4/10)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Add a test
PR-URL: #47706
 Reviewed-By: Joyee Cheung [email protected]
 Reviewed-By: Anna Henningsen [email protected]
[detached HEAD 80840620cd] Add a test
 Author: Shu-yu Guo [email protected]
 Date: Tue May 2 13:49:57 2023 -0700
 1 file changed, 23 insertions(+)
 create mode 100644 test/parallel/test-experimental-shared-value-conveyor.js
 Rebasing (5/10)
 Rebasing (6/10)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Fix linter errors
PR-URL: #47706
 Reviewed-By: Joyee Cheung [email protected]
 Reviewed-By: Anna Henningsen [email protected]
[detached HEAD 5e3d362c49] Fix linter errors
 Author: Shu-yu Guo [email protected]
 Date: Tue May 2 14:14:40 2023 -0700
 1 file changed, 2 insertions(+), 2 deletions(-)
 Rebasing (7/10)
 Rebasing (8/10)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Update test/parallel/test-experimental-shared-value-conveyor.js
Co-authored-by: Joyee Cheung [email protected]
 PR-URL: #47706
 Reviewed-By: Joyee Cheung [email protected]
 Reviewed-By: Anna Henningsen [email protected]
[detached HEAD f884cd13a6] Update test/parallel/test-experimental-shared-value-conveyor.js
 Author: Shu-yu Guo [email protected]
 Date: Fri May 5 17:09:16 2023 -0400
 1 file changed, 3 insertions(+), 1 deletion(-)
 Rebasing (9/10)
 Rebasing (10/10)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 Quell linter
PR-URL: #47706
 Reviewed-By: Joyee Cheung [email protected]
 Reviewed-By: Anna Henningsen [email protected]
[detached HEAD 2ad3799a03] Quell linter
 Author: Shu-yu Guo [email protected]
 Date: Fri May 5 15:05:18 2023 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4923112701

[nodejs-github-bot]

Landed in b2f6eed