benchmark: add bar.R#47729
Merged
benchmark: add bar.R #47729
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Apr 26, 2023
Review requested:
|
Contributor
mscdex commented Apr 26, 2023
I'm no R expert, so I can't comment on the code, however it might be better to base a new script like this off of the existing scatter.R script instead (notably it doesn't generate the unnecessary table of results like the normal benchmark R script does). |
Signed-off-by: RafaelGSS <[email protected]>
MemberAuthor
Sorry delay. That should be ready to review now. cc: @nodejs/performance |
anonrig approved these changes Jun 27, 2023
marco-ippolito approved these changes Jun 28, 2023
RafaelGSS added the commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 28, 2023
Landed in affc6ac |
RafaelGSS added a commit that referenced this pull request Jul 3, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #47729 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#47729 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#47729 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #47729 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #47729 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a few Node.js benchmarks and generating a barplot is quite helpful for comparisons when the standard deviation is slight. I'm using the
bar.Rin my next report and I thought would be good to have it available in the benchmark folder.Example: