worker: use snapshot in workers spawned by workers#47731
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously we didn't pass the snapshot data down to the isolate data of workers so workers spawned by workers won't use the snapshot. Fixes it by passing the snapshot data down.
nodejs-github-bot added c++ 
Collaborator
nodejs-github-bot commented Apr 26, 2023
35 tasks
anonrig approved these changes Apr 27, 2023
addaleax approved these changes Apr 27, 2023
29 tasks
MemberAuthor
Test failures are relevant - we need to move initialization of the per-isolate properties to the per-isolate initializers, otherwise the workers would attempt to recreate the per-isolate properties that are already deserialized from the isolate snapshot. I opened #47768 to unblock this. |
This was referenced Apr 29, 2023
Collaborator
nodejs-github-bot commented May 3, 2023
benjamingr approved these changes May 3, 2023
28 tasks
legendecas approved these changes May 4, 2023
Collaborator
nodejs-github-bot commented May 4, 2023
joyeecheung added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 4, 2023
Landed in 3bca5c2 |
This was referenced May 5, 2023
targos pushed a commit that referenced this pull request May 12, 2023
Previously we didn't pass the snapshot data down to the isolate data of workers so workers spawned by workers won't use the snapshot. Fixes it by passing the snapshot data down. PR-URL: #47731 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we didn't pass the snapshot data down to the isolate data of workers so workers spawned by workers won't use the snapshot. Fixes it by passing the snapshot data down.