quic: address recent coverity warning#47753
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Address coverity warning about uninitialized value Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot added c++ 
MemberAuthor
mhdawson commented Apr 27, 2023
Related coverity warning 128QuicError::QuicError(const std::string_view reason) 2. uninit_member: Non-staticclassmember error_.type is not initialized in this constructor nor in any functions that it calls. 4. uninit_member: Non-staticclassmember error_.error_code is not initialized in this constructor nor in any functions that it calls. 6. uninit_member: Non-staticclassmember error_.frame_type is not initialized in this constructor nor in any functions that it calls. 8. uninit_member: Non-staticclassmember error_.reason is not initialized in this constructor nor in any functions that it calls. CID 312510 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR) 10. uninit_member: Non-static class member error_.reasonlen is not initialized in this constructor nor in any functions that it calls. |
jasnell approved these changes Apr 27, 2023
VoltrexKeyva approved these changes Apr 28, 2023
debadree25 added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Apr 28, 2023
anonrig approved these changes Apr 30, 2023
Collaborator
nodejs-github-bot commented May 1, 2023
lpinca approved these changes May 2, 2023
33 tasks
28 tasks
Collaborator
nodejs-github-bot commented May 4, 2023
Collaborator
nodejs-github-bot commented May 4, 2023
anonrig added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 4, 2023
Landed in d900912 |
This was referenced May 5, 2023
targos pushed a commit that referenced this pull request May 12, 2023
Address coverity warning about uninitialized value Signed-off-by: Michael Dawson <[email protected]> PR-URL: #47753 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Address coverity warning about uninitialized value Signed-off-by: Michael Dawson <[email protected]> PR-URL: #47753 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Address coverity warning about uninitialized value Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#47753 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address coverity warning about uninitialized value