test: refactor to use getEventListeners in timers#47759
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use `getEventListeners` instead of `listenerCount` because nodejs#35991 was landed. Refs: nodejs#35991 Refs: nodejs#36006
nodejs-github-bot added needs-ci 
daeyeon approved these changes Apr 29, 2023
daeyeon added request-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Apr 29, 2023
This was referenced Apr 30, 2023
Collaborator
nodejs-github-bot commented May 1, 2023
ContributorAuthor
deokjinkim commented May 1, 2023
@benjamingr PTAL because this PR fixes comment you leaved. |
benjamingr approved these changes May 1, 2023
Mesteery approved these changes May 1, 2023
32 tasks
deokjinkim added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented May 2, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47759 ✔ Done loading data for nodejs/node/pull/47759 ----------------------------------- PR info ------------------------------------ Title test: refactor to use `getEventListeners` in timers (#47759) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230428_test_getEventListeners -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: refactor to use `getEventListeners` in timers Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/47759 Refs: https://github.com/nodejs/node/pull/35991 Refs: https://github.com/nodejs/node/pull/36006 Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47759 Refs: https://github.com/nodejs/node/pull/35991 Refs: https://github.com/nodejs/node/pull/36006 Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 28 Apr 2023 07:03:59 GMT ✔ Approvals: 3 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/47759#pullrequestreview-1406739223 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407438184 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407449072 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-05-01T07:59:33Z: https://ci.nodejs.org/job/node-test-pull-request/51558/ - Querying data for job/node-test-pull-request/51558/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4864775612 |
deokjinkim added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 2, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47759 ✔ Done loading data for nodejs/node/pull/47759 ----------------------------------- PR info ------------------------------------ Title test: refactor to use `getEventListeners` in timers (#47759) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230428_test_getEventListeners -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: refactor to use `getEventListeners` in timers Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/47759 Refs: https://github.com/nodejs/node/pull/35991 Refs: https://github.com/nodejs/node/pull/36006 Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47759 Refs: https://github.com/nodejs/node/pull/35991 Refs: https://github.com/nodejs/node/pull/36006 Reviewed-By: Daeyeon Jeong Reviewed-By: Benjamin Gruenbaum Reviewed-By: Mestery -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 28 Apr 2023 07:03:59 GMT ✔ Approvals: 3 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/47759#pullrequestreview-1406739223 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407438184 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/47759#pullrequestreview-1407449072 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-05-02T19:02:04Z: https://ci.nodejs.org/job/node-test-pull-request/51558/ - Querying data for job/node-test-pull-request/51558/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4865062346 |
nodejs-github-bot added the commit-queue-failed 33 tasks
deokjinkim added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 3, 2023
Landed in b0ca770 |
targos pushed a commit that referenced this pull request May 3, 2023
Use `getEventListeners` instead of `listenerCount` because #35991 was landed. Refs: #35991 Refs: #36006 PR-URL: #47759 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this pull request May 3, 2023
Use `getEventListeners` instead of `listenerCount` because #35991 was landed. Refs: #35991 Refs: #36006 PR-URL: #47759 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mestery <[email protected]>
28 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Use `getEventListeners` instead of `listenerCount` because #35991 was landed. Refs: #35991 Refs: #36006 PR-URL: #47759 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mestery <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Use `getEventListeners` instead of `listenerCount` because nodejs#35991 was landed. Refs: nodejs#35991 Refs: nodejs#36006 PR-URL: nodejs#47759 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Mestery <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
getEventListenersinstead oflistenerCountbecause #35991 was landed.Refs: #35991
Refs: #36006