Skip to content

vm,lib: refactor microtaskQueue assignment logic#47765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XadillaX wants to merge 1 commit into from
Closed

vm,lib: refactor microtaskQueue assignment logic #47765

XadillaX wants to merge 1 commit into from

Conversation

@XadillaX
Copy link
Contributor

@XadillaXXadillaX commented Apr 28, 2023

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 28, 2023
@XadillaX
vm,lib: refactor microtaskQueue assignment logic
c57c126
Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability.
@XadillaXXadillaX changed the title vm: remove an unnecessary microtaskMode conditionvm,lib: refactor microtaskQueue assignment logicApr 29, 2023
@XadillaXXadillaX requested a review from addaleaxApril 30, 2023 00:53
yorkie
yorkie reviewed Apr 30, 2023
View reviewed changes
Copy link
Contributor

@yorkieyorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks easiler to read to me :)

@theanarkhtheanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51559/

This was referenced May 3, 2023
Open
Open
@XadillaXXadillaX added the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51690/

@XadillaXXadillaX removed the request for review from addaleaxMay 13, 2023 14:07
XadillaX added a commit that referenced this pull request May 13, 2023
@XadillaX
vm,lib: refactor microtaskQueue assignment logic
23e6b12
Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability. PR-URL: #47765 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@XadillaX
Copy link
ContributorAuthor

XadillaX commented May 13, 2023

Landed in 23e6b12

targos pushed a commit that referenced this pull request May 14, 2023
@XadillaX@targos
vm,lib: refactor microtaskQueue assignment logic
931874c
Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability. PR-URL: #47765 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
@XadillaX@targos
vm,lib: refactor microtaskQueue assignment logic
e6685f9
Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability. PR-URL: #47765 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@XadillaX@danielleadams
vm,lib: refactor microtaskQueue assignment logic
1f2b5f6
Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability. PR-URL: #47765 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@XadillaX@MoLow
vm,lib: refactor microtaskQueue assignment logic
4b2aa3d
Simplify the assignment of the `microtaskQueue` variable in the `vm` module by replacing the conditional block with a more concise ternary operator. This change improves code readability and maintainability. PR-URL: nodejs#47765 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@theanarkhtheanarkhtheanarkh approved these changes

+2 more reviewers

@yorkieyorkieyorkie left review comments

@MesteeryMesteeryMesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XadillaX@nodejs-github-bot@lpinca@yorkie@theanarkh@Mesteery