test: fix webcrypto wrap unwrap tests#47876
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
panva added crypto 
tniessen approved these changes May 5, 2023
panva added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented May 5, 2023
MemberAuthor
panva commented May 5, 2023
Note: the tests did actually execute before, but would cause an unhandled rejection in the file if they failed instead of reporting properly. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented May 5, 2023
Collaborator
nodejs-github-bot commented May 5, 2023
lpinca approved these changes May 5, 2023
panva added the commit-queue This was referenced May 6, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented May 7, 2023
Landed in ecf1427 |
This was referenced May 8, 2023
targos pushed a commit that referenced this pull request May 12, 2023
Refs: #47864 PR-URL: #47876 Refs: #47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Refs: #47864 PR-URL: #47876 Refs: #47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Refs: nodejs#47864 PR-URL: nodejs#47876 Refs: nodejs#47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrap/unwrap promises are now properly handled.
Refs: #47864
cc @tniessen@fhanau