lib: move web global bootstrapping to the expected file#47881
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot commented May 5, 2023
Review requested:
|
nodejs-github-bot added lib / src 
Uh oh!
There was an error while loading. Please reload this page.
github-actionsbot removed the request-ci nodejs-github-bot commented May 9, 2023
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
Could this be considered semver-major?
legendecas commented May 10, 2023
This doesn't affect users that don't utilize |
legendecas added the semver-major nodejs-github-bot commented May 12, 2023
I would argue that it's a fix, not a breaking change. In all likeliness, folks using |
I was under the impression that changes to the global are semver-major. Unfortunately, I didn't find a written rule for it. Regarding the semantic of the flag @codebytere would you mind helping out here to see if un-exposing the |
legendecas added commit-queue-rebase nodejs-github-bot removed the commit-queue nodejs-github-bot commented Jun 15, 2023
Landed in f3b713d...ee1b6ab |
PR-URL: #47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: #47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: #47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: #47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: nodejs#47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: nodejs#47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: nodejs#47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
PR-URL: nodejs#47881 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
ruyadorno commented Sep 8, 2023
This commit does not land cleanly on |
9 participants
Moves the definition of
queueMicrotaskandstructuredClonetointernal/bootstrap/web/exposed-window-or-worker.jsas they are defined in HTMLWindowOrWorkerGlobalScope. This also suggests they can be disabled with the option--no-browser--globals.Also, remove the obsolete deletion
bufferBinding.zeroFill.