Skip to content

Conversation

@rluvaton
Copy link
Member

@rluvatonrluvaton commented May 6, 2023

How would you suggest I add a test for this?, I'm trying to avoid overridden process.stdout.columns

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 6, 2023
@MoLow
Copy link
Member

MoLow commented May 7, 2023

commit messages prefix should be test_runner:, not test:, besides that - maybe add a pseudo-tty test?

@rluvaton
Copy link
MemberAuthor

Closed in favor of #48038

@rluvatonrluvaton deleted the display-dot-as-wide-as-the-terminal branch May 16, 2023 21:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rluvaton@nodejs-github-bot@MoLow