tools: debug log for nghttp3#47992
Merged
tools: debug log for nghttp3 #47992
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
marco-ippolito added the fast-track 
Contributor
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
anonrig approved these changes May 13, 2023
juanarbol approved these changes May 13, 2023
Member
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
Do GitHub files have stable checksums? If so, it would be good to log the sha256sum or so of the downloaded archive.
MemberAuthor
marco-ippolito commented May 14, 2023
This is a good idea! It might be something we want to do for all archive we download. Ill look into it |
deokjinkim approved these changes May 14, 2023
jasnell approved these changes May 14, 2023
marco-ippolito added the commit-queue 
nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented May 14, 2023
Landed in d27301d |
targos pushed a commit that referenced this pull request May 14, 2023
PR-URL: #47992 Refs: #47576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
PR-URL: #47992 Refs: #47576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47992 Refs: #47576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47992 Refs: nodejs#47576 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #47576