Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
tools: add support for subkeys in release tools#4807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
3c6a93f to af1f38cCompareaf1f38c to 3bf7733Comparetools/release.sh Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% we want to be using the -E flag here. Personally I don't see a problem, but perhaps we want to solve this without using an extended regular expression
Fishrock123 commented Jan 22, 2016
As a note, my subkey works, but it always prints the |
MylesBorins commented Jan 25, 2016
Any thoughts on this @rvagg ? |
rvagg commented Jan 26, 2016
Yeah, this works, I was working up a complicated solution in my head but the fact that this simply prompts you to choose makes it a simple fix! Good thinking.
lgtm with that change. |
3bf7733 to 403659fCompare403659f to c219ad1CompareMylesBorins commented Jan 26, 2016
@rvagg I added the change and rebased against master |
c219ad1 to 726bea7Comparervagg commented Jan 26, 2016
lgtm, I think you can probably land this at will now, thanks @thealphanerd! |
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <[email protected]>
MylesBorins commented Jan 26, 2016
Landed in 321162d |
726bea7 to 321162dCompareReplace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys PR-URL: #4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys PR-URL: nodejs#4807 Reviewed-By: Rod Vagg <[email protected]>
Replace grep with awk to add support for subkeys
/cc @rvagg@jasnell@Fishrock123 @nodejs/build