repl: display dynamic import version in error message.

[hemanth]

Fix for #48084

❯./out/Release/nodeWelcometoNode.jsv21.0.0-pre.Type".help"formoreinformation.>import{foo,bar}from'mo';import{foo,bar}from'mo';^^^^^^ Uncaught: SyntaxError: CannotuseimportstatementinsidetheNode.jsREPL,alternativelyusedynamicimport: const{foo,bar}=awaitimport('mo');

[aduh95]

Can you please remove the unrelated spacing changes, and ensure we have a test for all types of static import statements as well as tests for when there are more than one statement (e.g. const a=1;import 'url';const b=2).

[hemanth]

@aduh95 I ran make lint-js-fix, looks better now?

const a=1;import 'url';const b=2 that's a good catch, pretty sure that would bomb, will have a look.

update: ha! will fix it.

>const a=1;import 'url';const b=2 const a=1;import 'url';const b=2 ^^^^^^ Uncaught: SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import: const = await import('url'); 

Meanwhile, any idea, why this could happen? Looks like a parse error?

> import comeOn from \'fhqwhgads\' Uncaught [SyntaxError: Expecting Unicode escape sequence \uXXXX (1:20) ]{pos: 20, loc: Position{line: 1, column: 20 }, raisedAt: 20 } 

[aduh95]

import comeOn from \'fhqwhgads\' is not valid ECMAScript (mind the backslashes), so it's expected that it produces a parse error, or am I missing something?

[hemanth]

On v20.1.0 we see:

❯ node Welcome to Node.js v20.1.0. Type ".help" for more information. > import comeOn from \'fhqwhgads\' import comeOn from \'fhqwhgads\' ^^^^^^ Uncaught: SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import 

^ That should be because it doesn't even parse till \'fhqwhgads\' so the expected behavior with the new messaging would be?

[hemanth]

Works in runkit, because it interpolates the string well?

[hemanth]

@aduh95 How come the test passes for:

{send: 'import "foo";',expect: ''}

❯ tools/test.py test/parallel/test-repl-* [00:03|% 100|+ 72|- 0]: Done All tests passed. 

[hemanth]

@aduh95internal/deps/acorn/acorn/dist/acorn and internal/deps/acorn/acorn-walk/dist/walk have different implementations compared what is on npm.

Currently stuck with:

UncaughtTypeError: baseVisitor[type]isnotafunctionatc(node:internal/deps/acorn/acorn-walk/dist/walk:45:24)atObject.ancestor(node:internal/deps/acorn/acorn-walk/dist/walk:48:7)attoDynamicImport(node:repl:238:13)atDomain.debugDomainError(node:repl:713:62)atDomain.emit(node:events:511:28)atDomain.emit(node:domain:489:12)atfinish(node:repl:949:22)atfinishExecution(node:repl:571:7)atREPLServer.defaultEval(node:repl:660:7)atbound(node:domain:433:15)

Parser(options, input, startPos) param positions are different...

[aduh95]

That's unlikely, we use npm to download new versions.

node/tools/dep_updaters/update-acorn.sh

Line 36 in 300f68e

"$NODE""$NPM" install --global-style --no-bin-links --ignore-scripts "acorn@$NEW_VERSION"

[hemanth]

acron#L9 reads constructor(options, input, startPos) their readme interface readsparse(input, options) ha, maybe it is parse vs Parser.

Also, everything works fine in runkit gist.

[hemanth]

Ah, indeed it was Parser vs parse.

 code: 'ERR_ASSERTION', actual: "SyntaxError: Cannot use import statement inside the Node.js REPL, alternatively use dynamic import: const comeOn = await import('fhqwhgads');", expected: /^SyntaxError: .* dynamic import: const comeOn = await import('fhqwhgads');/, operator: 'match' 

RE is not being respected? /^SyntaxError: .* dynamic import:..

[hemanth]

Build says: Error: The operation was canceled.@aduh95 is there a keyword to re-trigger CI?

Also, finally looks like we have all the variants covered:

[aduh95]

If you push a commit to get rid of all the unrelated space changes, that should trigger a new CI run

[hemanth]

Ha! The spaces changes came in from lint-fix I presume.

…

On Sat, May 27, 2023, 8:09 AM Antoine du Hamel ***@***.***> wrote: If you push a commit to get rid of all the unrelated space changes, that should trigger a new CI run — Reply to this email directly, view it on GitHub <#48129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEPC2G3CGRJY4ACLMNOO3XIIKKLANCNFSM6AAAAAAYLC4TYY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[aduh95]

The spaces changes came in from lint-fix I presume.

That's unlikely, but anyway, you would need to get rid of the unrelated changes to move this forward.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52190/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52200/

[nodejs-github-bot]

Landed in 0c875bb

[hemanth]

🥳 Thank you @aduh95 and @ljharb 🤓

[ruyadorno]

hi @hemanth this commit is breaking tests on v18.x-staging branch and will need manual backport in order to land on v18.

[hemanth]

Hey @ruyadorno Ill try to backport it, thanks for highlighting!