Skip to content

Conversation

@shipujin
Copy link
Member

@shipujinshipujin commented May 23, 2023

Add linux64-loongarch64 into Makefile
And run make

PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michael Dawson [email protected]

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels May 23, 2023
@shipujin
Copy link
MemberAuthor

Add linux64-loongarch64 into Makefile
And run make

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51993/

@shipujinshipujinforce-pushed the loong64-dev-v18.x-staging branch from 2bb7539 to 8f8bafcCompareJune 26, 2023 08:24
@shipujin
Copy link
MemberAuthor

Update

@nodejs-github-bot
Copy link
Collaborator

@shipujin
Copy link
MemberAuthor

Hi @danielleadams ,I have verified and updated this patch on my computer. Could you please help review this patch.
thx~

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52723/

@Trott
Copy link
Member

Trott commented Aug 3, 2023

@ruyadorno Is this something that might end up in the next 18.x release. (According to nodejs/Release#737, you're doing the 18.x release for August 2023. Apologies if I'm doing things wrong and you're not the person to ping!)

ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
Add linux64-loongarch64 into Makefile And run make PR-URL: #46401 Backport-PR-URL: #48135 Reviewed-By: Ben Noordhuis [email protected] Reviewed-By: James M Snell [email protected] Reviewed-By: Michael Dawson [email protected]
@ruyadorno
Copy link
Member

Landed in f4617a4

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file.needs-ciPRs that need a full CI run.opensslIssues and PRs related to the OpenSSL dependency.v18.xIssues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shipujin@nodejs-github-bot@Trott@ruyadorno