build: relax upper limit on python version check#48136
Uh oh!
There was an error while loading. Please reload this page.
Conversation
We can't entirely remove the limit because we want to print a helpful message with python installs we found but we can at least relax it to a much wider range. Python 3.x is very likely compatible with 3.x-1 so don't be too uptight about what versions we accept, as long as it's python >= 3.6. Refs: nodejs#48130
nodejs-github-bot added build 
sxa commented May 23, 2023
Noting that when I suggested relaxing the version check (Giving the user information on how to override it if they wanted to do so at their own risk) it was rejected: #41051 So while I'd be in favour of this as an even more strong solution that what I proposed, there may be disagreement elsewhere ;-) |
Trott added the python 
Trott commented May 23, 2023
@nodejs/python |
From my perspective, I would like us to use https://devguide.python.org/versions as our metric. If the Python Core Team supports a version of Python then we should also support it. Python 3.6 is EOL (since 2021) and Python 3.12 is currently If folks want to use EOL or pre-release versions of Python then we should provide minimal (not recommended) support. If folks are paying for long-term support for an OS that has an EOL version of Python then their OS provider can support them and we are no longer obliged to do so. If folks are using an OS that is beyond the standard support and are not paying for LTS, then their problems are not for us to solve. Building on secure platforms and being able to use new language optimizations and features helps both our safety and velocity. Python 3.11 is 25% faster than Python 3.10 and this optimization trend will continue in Py3.12 and then 3.13 annual releases. Supporting four versions of Python is sufficient. Let's encourage security and performance upgrades. |
| ifsys.version_info[:2] in acceptable_pythons: | ||
| major, minor, patch = sys.version_info[:3] | ||
| print('Node.js configure: Found Python{}.{}.{}...'.format(major, minor, patch)) | ||
| ifmajor > 3 or major == 3 and minor >= 6: |
There was a problem hiding this comment.
| if major > 3 or major == 3 and minor >= 6: | |
| if sys.version_info >= (3, 8): |
github-actionsbot removed the request-ci 
nodejs-github-bot commented Jul 13, 2023
AdamMajer commented Aug 10, 2023
This just managed to hit a snag with Python 3.12 in Fedora Rawhide. distutils was removed, so https://peps.python.org/pep-0632/ Simply relaxing the check, while it works most of the time, it can cause issues when not tested. |
aduh95 commented May 11, 2024
This needs a rebase. |
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
8 participants
We can't entirely remove the limit because we want to print a helpful message with python installs we found but we can at least relax it to a much wider range.
Python 3.x is very likely compatible with 3.x-1 so don't be too uptight about what versions we accept, as long as it's python >= 3.6.
Refs: #48130