Code style: always-parens for arrow functions#4814
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
jasnell commented Jan 22, 2016
I'm good with this. LGTM |
MemberAuthor
rvagg commented Jan 22, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on from here. While single-argument arrow functions allow you to drop parens, it doesn't mean you should. Personally I find these too terse and make code harder to visually parse. I know I'm not alone on this but I'm happy to hear from others who feel strongly about dropping parens in this case.
Note our codebase isn't consistent on this, there's lots of single-arg arrow functions with parens already.
/cc @nodejs/collaborators cause of the impact