Skip to content

Conversation

@mhdawson
Copy link
Member

My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time.

  • Removing the need for the lable
  • Remove the cron scheduling so that it only runs when I run it manually
  • Fix the display name for the action as I missed updating that after cut and paste from existing action

The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead.

My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 26, 2023
mhdawson added a commit that referenced this pull request Jun 5, 2023
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48196 Reviewed-By: Mestery <[email protected]>
@mhdawson
Copy link
MemberAuthor

Landed in 41f8abc

@MesteeryMesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2023
@MesteeryMesteery closed this Jun 5, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48196 Reviewed-By: Mestery <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48196 Reviewed-By: Mestery <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
My original plan of adding a lable to limit those initially process as outlined in nodejs#48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48196 Reviewed-By: Mestery <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48196 Reviewed-By: Mestery <[email protected]>
@ruyadornoruyadorno mentioned this pull request Aug 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mhdawson@nodejs-github-bot@Mesteery