test: refactor test-gc-http-client-timeout#48292
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
santigimeno approved these changes Jun 2, 2023
Due to server response delay, all possible requests are created anyway. Instead of doing `36 * os.availableParallelism()` requests, use a fixed number. Refs: nodejs#48078 (comment)
lpincaforce-pushed the refactor/test-gc-http-client-timeout branch from c8d2b12 to e5521d2Compare
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jun 2, 2023
Trott approved these changes Jun 2, 2023
33 tasks
anonrig approved these changes Jun 3, 2023
anonrig added the author ready Collaborator
nodejs-github-bot commented Jun 3, 2023
MemberAuthor
CI always fails. See #48300. |
jasnell approved these changes Jun 3, 2023
LiviaMedeiros approved these changes Jun 3, 2023
This was referenced Jun 4, 2023
Collaborator
nodejs-github-bot commented Jun 5, 2023
20 tasks
Collaborator
nodejs-github-bot commented Jun 6, 2023
watilde approved these changes Jun 6, 2023
Collaborator
nodejs-github-bot commented Jun 6, 2023
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 6, 2023
Landed in f351c8a |
24 tasks
This was referenced Jun 10, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
Due to server response delay, all possible requests are created anyway. Instead of doing `36 * os.availableParallelism()` requests, use a fixed number. Refs: #48078 (comment) PR-URL: #48292 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Due to server response delay, all possible requests are created anyway. Instead of doing `36 * os.availableParallelism()` requests, use a fixed number. Refs: nodejs#48078 (comment) PR-URL: nodejs#48292 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Due to server response delay, all possible requests are created anyway. Instead of doing `36 * os.availableParallelism()` requests, use a fixed number. Refs: nodejs#48078 (comment) PR-URL: nodejs#48292 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
Due to server response delay, all possible requests are created anyway. Instead of doing `36 * os.availableParallelism()` requests, use a fixed number. Refs: #48078 (comment) PR-URL: #48292 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to server response delay, all possible requests are created anyway. Instead of doing
36 * os.availableParallelism()requests, use a fixed number.Refs: #48078 (comment)