bootstrap: simplify initialization of source map handlers#48304
+28 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
joyeecheung commented Jun 2, 2023
joyeecheung commented - Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot.
- Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution.
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution.
Collaborator
nodejs-github-bot commented Jun 2, 2023
Review requested:
|
nodejs-github-bot added lib / src 
anonrig approved these changes Jun 2, 2023
VoltrexKeyva approved these changes Jun 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
jasnell approved these changes Jun 3, 2023
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM with the linting issues fixed.
legendecas approved these changes Jun 6, 2023
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
Collaborator
nodejs-github-bot commented Jun 6, 2023
Collaborator
nodejs-github-bot commented Jun 7, 2023
Collaborator
nodejs-github-bot commented Jun 8, 2023
joyeecheung added commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Jun 8, 2023
Commit Queue failed- Loading data for nodejs/node/pull/48304 ✔ Done loading data for nodejs/node/pull/48304 ----------------------------------- PR info ------------------------------------ Title bootstrap: simplify initialization of source map handlers (#48304) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:source-map-init -> nodejs:main Labels process, lib / src, needs-ci, commit-queue-squash Commits 2 - bootstrap: simplify initialization of source map handlers - fixup! bootstrap: simplify initialization of source map handlers Committers 2 - Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/48304 Reviewed-By: Yagiz Nizipli Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: James M Snell Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48304 Reviewed-By: Yagiz Nizipli Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: James M Snell Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup! bootstrap: simplify initialization of source map handlers ℹ This PR was created on Fri, 02 Jun 2023 17:53:13 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/48304#pullrequestreview-1458168465 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/48304#pullrequestreview-1458238733 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/48304#pullrequestreview-1459828667 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/48304#pullrequestreview-1464502401 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-08T08:43:09Z: https://ci.nodejs.org/job/node-test-pull-request/52158/ - Querying data for job/node-test-pull-request/52158/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5216112521 |
joyeecheung added a commit that referenced this pull request Jun 9, 2023
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: #48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
MemberAuthor
joyeecheung commented Jun 9, 2023
Landed in 4ff55ec |
This was referenced Jun 11, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: #48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: nodejs#48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: nodejs#48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Member
ruyadorno commented Aug 29, 2023
hi @joyeecheung these commits are not landing cleanly on |
targos pushed a commit that referenced this pull request Nov 10, 2023
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: #48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: nodejs/node#48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: nodejs/node#48304 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.