deps: update ada to 2.5.1#48319

nodejs-github-bot · 2023-06-03T16:46:13Z

This is an automated update of ada to 2.5.1.

nodejs-github-bot · 2023-06-03T16:46:17Z

Review requested:

@nodejs/url

anonrig · 2023-06-03T16:53:59Z

I added changes to this pull request, since these changes are required for the web platform tests to update.

This PR fixes: #48157

github-actions · 2023-06-03T16:57:05Z

Fast-track has been requested by @anonrig. Please 👍 to approve.

nodejs-github-bot · 2023-06-03T17:08:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52071/

anonrig · 2023-06-03T17:26:38Z

PS: This pull request includes a bug fix (for URLs that contain 0 port number), as well as a fix for the spec compliance on URL getter.

aduh95 · 2023-06-03T17:57:14Z

node/doc/contributing/collaborator-guide.md

Lines 543 to 544 in 260092e

 All commits should be self-contained, meaning every commit should pass all 
 tests. This makes it much easier when bisecting to find a breaking change. 

I guess we would need to squash 019723c and c3a1c64 upon landing, right? Or maybe land c3a1c64 first and update the status when upgrading ada.

anonrig · 2023-06-03T18:24:25Z

@aduh95 We don't need to squash since all commits build correctly. In the second commit, I added url origin getter to url.json wpt file, and in 3rd I removed it. But even with wpt files update commit, everything works correctly.

nodejs-github-bot · 2023-06-03T23:56:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52076/

nodejs-github-bot · 2023-06-04T03:32:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52078/

nodejs-github-bot · 2023-06-04T18:42:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52089/

nodejs-github-bot · 2023-06-05T13:20:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52102/

nodejs-github-bot · 2023-06-05T20:01:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52116/

nodejs-github-bot · 2023-06-05T22:42:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52118/

nodejs-github-bot · 2023-06-07T11:42:05Z

Landed in 23c7f65...f2670a6

PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: nodejs#48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jun 3, 2023

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 3, 2023

lpinca approved these changes Jun 3, 2023
View reviewed changes

anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 3, 2023

anonrig requested a review from lpinca June 3, 2023 16:52

anonrig approved these changes Jun 3, 2023
View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 3, 2023

lpinca approved these changes Jun 3, 2023
View reviewed changes

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 3, 2023

benjamingr approved these changes Jun 3, 2023
View reviewed changes

github-actionsbot mentioned this pull request Jun 4, 2023
CI Reliability 2023-06-04 nodejs/reliability#585
Open
30 tasks

github-actionsbot mentioned this pull request Jun 5, 2023
CI Reliability 2023-06-05 nodejs/reliability#586
Open
30 tasks

anonrig force-pushed the actions/tools-update-ada branch from 2fb0e11 to 99bdf92Compare June 5, 2023 13:15

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023

github-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023

anonrig approved these changes Jun 5, 2023
View reviewed changes

deps: update ada to 2.5.1
53893b8

github-actionsbot mentioned this pull request Jun 6, 2023
CI Reliability 2023-06-06 nodejs/reliability#587
Open
20 tasks

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023

anonrig approved these changes Jun 7, 2023
View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023

nodejs-github-bot closed this Jun 7, 2023

nodejs-github-bot added a commit that referenced this pull request Jun 7, 2023
deps: update ada to 2.5.1
11bd9f9
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2023
test: update url web-platform tests
e6e0110
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2023
url: conform to origin getter spec changes
f2670a6
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

targos deleted the actions/tools-update-ada branch June 7, 2023 11:47

This was referenced Jun 9, 2023
CI Reliability 2023-06-09 nodejs/reliability#588
Open
CI Reliability 2023-06-10 nodejs/reliability#589
Open

hemanth mentioned this pull request Jun 11, 2023
url: origin of "blob:" URL containing inner non-"http(s):" URL #48168
Closed

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
deps: update ada to 2.5.1
8cd56c1
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
test: update url web-platform tests
764119b
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
url: conform to origin getter spec changes
fafe651
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
deps: update ada to 2.5.1
262f965
PR-URL: nodejs#48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: update url web-platform tests
0bdbf9d
PR-URL: nodejs#48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
deps: update ada to 2.5.1
d467e03
PR-URL: nodejs#48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
test: update url web-platform tests
5ba5335
PR-URL: nodejs#48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
deps: update ada to 2.5.1
a2964a4
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
test: update url web-platform tests
cb92c4b
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
url: conform to origin getter spec changes
d428e6b
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

ruyadorno mentioned this pull request Aug 29, 2023
v18.18.0 proposal #49220
Merged

ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
url: conform to origin getter spec changes
f59c963
PR-URL: #48319 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Uh oh!

deps: update ada to 2.5.1#48319

deps: update ada to 2.5.1 #48319

Uh oh!

Conversation

nodejs-github-bot commented Jun 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 3, 2023

Uh oh!

anonrig commented Jun 3, 2023

Uh oh!

github-actionsbot commented Jun 3, 2023

Uh oh!

nodejs-github-bot commented Jun 3, 2023

Uh oh!

anonrig commented Jun 3, 2023

Uh oh!

aduh95 commented Jun 3, 2023

Uh oh!

anonrig commented Jun 3, 2023

Uh oh!

nodejs-github-bot commented Jun 3, 2023

Uh oh!

nodejs-github-bot commented Jun 4, 2023

Uh oh!

nodejs-github-bot commented Jun 4, 2023

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

nodejs-github-bot commented Jun 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nodejs-github-bot commented Jun 3, 2023•
edited
Loading