doc: add additional info on TSFN dispatch#48367
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Refs: nodejs#48356 Signed-off-by: Michael Dawson <[email protected]>
Collaborator
nodejs-github-bot commented Jun 6, 2023
Review requested:
|
nodejs-github-bot added doc 
MemberAuthor
Implementation of dispatch is here: Line 350 in a929522 Currently at least 1 and up to 1000 callbacks in the queue will be invoked, but that I believe should be left as an implementation detail. Doc is updated to indicate that more than one can be invoked in tick, but there is no guarantee as to how many will be in any given tick. @nodejs/node-api does that seem reasonable to everybody? |
tniessen approved these changes Jun 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Chengzhong Wu <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
legendecas approved these changes Jun 10, 2023
mhdawson added a commit that referenced this pull request Jun 12, 2023
Refs: #48356 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48367 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
MemberAuthor
mhdawson commented Jun 12, 2023
Landed in 1da9099 |
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
Refs: #48356 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48367 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Refs: nodejs#48356 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48367 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Refs: nodejs#48356 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#48367 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
Refs: #48356 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48367 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Refs: #48356 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #48367 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #48356