test: add missing <algorithm> include for std::find#48380
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci 
ContributorAuthor
Sorry, this is identical to #48330 - I was playing with some github tooling to update local forks and messed it up (and it deleted the fork). Apologies for the hassle folks. |
LiviaMedeiros approved these changes Jun 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <[email protected]>
lpinca approved these changes Jun 7, 2023
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jun 7, 2023
KhafraDev approved these changes Jun 7, 2023
lpinca added request-ci 
debadree25 added author ready nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 9, 2023
Landed in ad0bbaf |
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <[email protected]> PR-URL: #48380 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <[email protected]> PR-URL: nodejs#48380 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <[email protected]> PR-URL: nodejs#48380 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <[email protected]> PR-URL: #48380 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <[email protected]> PR-URL: #48380 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 14 drops some transitive includes within libstdc++. Explicitly include for std::find.
Signed-off-by: Sam James [email protected]