test_runner: add enqueue and dequeue events#48428
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 11, 2023
Review requested:
|
nodejs-github-bot added needs-ci 
MemberAuthor
MoLow commented Jun 11, 2023
@sankalp1999 FWIW, if you want to complete the work on #47797 I will close this PR |
Uh oh!
There was an error while loading. Please reload this page.
cjihrig approved these changes Jun 11, 2023
Contributor
@MoLow sorry, I couldn't find the time. I think you can continue with this one. I will close my PR. Thank you for reviewing. |
anonrig reviewed Jun 11, 2023
| *`file`{string|undefined} The path of the test file, | ||
| undefined if test is not ran through a file. | ||
| *`name`{string} The test name. | ||
| *`nesting`{number} The nesting level of the test. |
Member
There was a problem hiding this comment.
Nit
Suggested change
| *`nesting`{number} The nesting level of the test. | |
| *`level`{number} The nesting level of the test. |
MemberAuthor
There was a problem hiding this comment.
nesting is already used on all other events on this class
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 12, 2023
Collaborator
nodejs-github-bot commented Jun 12, 2023
MoLow added the author ready 
benjamingr approved these changes Jun 12, 2023
| *`data`{Object} | ||
| *`file`{string|undefined} The path of the test file, | ||
| undefined if test is not ran through a file. |
Member
There was a problem hiding this comment.
Suggested change
| undefined if test is not ran through a file. | |
| undefined if test was not run through a file. |
MemberAuthor
There was a problem hiding this comment.
this exact terminology is used in 6 other places in this file, so I will fix it in a follow-up PR
| *`data`{Object} | ||
| *`file`{string|undefined} The path of the test file, | ||
| undefined if test is not ran through a file. |
Member
There was a problem hiding this comment.
What are you trying to say here?
"will not run" in this (and above) perhaps?
MemberAuthor
There was a problem hiding this comment.
I think running within REPL is the main example of this. Il refine this in a follow-up
| constfilename=`custom.${ext}`; | ||
| constchild=spawnSync(process.execPath, | ||
| ['--test','--test-reporter',fixtures.fileURL('test-runner/custom_reporters/',filename), | ||
| testFile]); |
Member
There was a problem hiding this comment.
Would be useful to also test the arguments
MoLow added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 13, 2023
Landed in 8bc6e19 |
29 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
PR-URL: nodejs#48428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
PR-URL: #48428 Backport-PR-URL: #48684 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
7 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#46727