Skip to content

build: sync libuv header change#48429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 14, 2023
Merged

build: sync libuv header change #48429

nodejs-github-bot merged 1 commit into from
Jun 14, 2023

Conversation

@gengjiawen
Copy link
Member

@gengjiawengengjiawen commented Jun 12, 2023

removed in libuv/libuv#3688

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2023

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Jun 12, 2023
@gengjiawengengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52217/

@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 12, 2023
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2023
@nodejs-github-botnodejs-github-bot merged commit b0e08d1 into nodejs:mainJun 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 14, 2023

Landed in b0e08d1

@gengjiawengengjiawen deleted the fix/uv_headers_sync branch June 14, 2023 07:01
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@gengjiawen@RafaelGSS
build: sync libuv header change
f7f3208
PR-URL: #48429 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@gengjiawen@Ceres6
build: sync libuv header change
d93eacc
PR-URL: nodejs#48429 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@gengjiawen@Ceres6
build: sync libuv header change
6f9041c
PR-URL: nodejs#48429 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@ruyadorno
Copy link
Member

ruyadorno commented Sep 8, 2023

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it to land in v18.

arsnyder16 pushed a commit to arsnyder16/node that referenced this pull request Sep 10, 2023
@gengjiawen@arsnyder16
build: sync libuv header change
497bf4a
PR-URL: nodejs#48429 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
@arsnyder16arsnyder16 mentioned this pull request Sep 10, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@gengjiawen@ruyadorno
build: sync libuv header change
e03aa5f
PR-URL: #48429 Backport-PR-URL: #49591 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@gengjiawen@ruyadorno
build: sync libuv header change
4b0c098
PR-URL: #48429 Backport-PR-URL: #49591 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@gengjiawen@ruyadorno
build: sync libuv header change
7dc731d
PR-URL: #48429 Backport-PR-URL: #49591 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> PR-URL: #48078
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimenosantigimenosantigimeno approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.libuvIssues and PRs related to the libuv dependency or the uv binding.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gengjiawen@nodejs-github-bot@ruyadorno@santigimeno@lpinca@targos@cjihrig@tniessen@aduh95@debadree25