Skip to content

stream: fix premature pipeline end#48435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 24, 2023
Merged

stream: fix premature pipeline end #48435

nodejs-github-bot merged 1 commit into from
Jun 24, 2023

Conversation

@ronag
Copy link
Member

@ronagronag commented Jun 12, 2023

Fixes: #48406

@ronagronag added the stream Issues and PRs related to the stream subsystem. label Jun 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2023

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 12, 2023
mcollina
mcollina approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 12, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52226/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52228/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52230/

lpinca
lpinca approved these changes Jun 12, 2023
View reviewed changes
@github-actionsgithub-actionsbot mentioned this pull request Jun 13, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52233/

@mcollina
Copy link
Member

mcollina commented Jun 13, 2023

@nodejs/build it seems we can't build on ARM.

@targos
Copy link
Member

targos commented Jun 13, 2023

Can you try with a full run instead of a rebuild?

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52235/

This was referenced Jun 14, 2023
Open
Open
@ronagronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/48435 ✔ Done loading data for nodejs/node/pull/48435 ----------------------------------- PR info ------------------------------------ Title stream: fix premature pipeline end (#48435) Author Robert Nagy (@ronag) Branch ronag:issue-48406 -> nodejs:main Labels stream, author ready, needs-ci Commits 1 - stream: fix premature pipeline end Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/48435 Fixes: https://github.com/nodejs/node/issues/48406 Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48435 Fixes: https://github.com/nodejs/node/issues/48406 Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jun 2023 13:17:11 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48435#pullrequestreview-1474986414 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475174694 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475278074 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48435#pullrequestreview-1475471197 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-06-13T09:28:07Z: https://ci.nodejs.org/job/node-test-pull-request/52235/ - Querying data for job/node-test-pull-request/52235/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5277325882

@freeatnetfreeatnet mentioned this pull request Jun 15, 2023
Closed
@debadree25debadree25 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 20, 2023
@github-actionsgithub-actionsbot mentioned this pull request Jun 21, 2023
Open
29 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52332/

@github-actionsgithub-actionsbot mentioned this pull request Jun 23, 2023
Open
30 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 23, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52402/

@github-actionsgithub-actionsbot mentioned this pull request Jun 24, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 24, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52415/

@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2023
@nodejs-github-botnodejs-github-bot merged commit cebbc57 into nodejs:mainJun 24, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 24, 2023

Landed in cebbc57

This was referenced Jun 25, 2023
Open
Open
Open
@mcollinamcollina mentioned this pull request Jun 29, 2023
Closed
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@ronag@RafaelGSS
stream: fix premature pipeline end
84d0eb7
Fixes: #48406 PR-URL: #48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ronag@Ceres6
stream: fix premature pipeline end
088d3a4
Fixes: nodejs#48406 PR-URL: nodejs#48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ronag@Ceres6
stream: fix premature pipeline end
21d60b3
Fixes: nodejs#48406 PR-URL: nodejs#48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
@ronag@ruyadorno
stream: fix premature pipeline end
a72af53
Fixes: #48406 PR-URL: #48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 10, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@ronag@ruyadorno
stream: fix premature pipeline end
786fbdb
Fixes: #48406 PR-URL: #48435 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
@simatecsimatec mentioned this pull request Oct 5, 2023
Closed
@teogebteogeb mentioned this pull request Jan 16, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@debadree25debadree25debadree25 approved these changes

@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream.pipeline abruptly kill the node process

8 participants

@ronag@nodejs-github-bot@mcollina@targos@benjamingr@lpinca@debadree25@marco-ippolito