module: add SourceMap.lineLengths#48461
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
anonrig reviewed Jun 15, 2023
Member
anonrig left a comment
anonrig left a comment There was a problem hiding this comment.
Can you update the documentation as well?
isaacsforce-pushed the isaacs/expose-source-maps-line-lengths branch from b2376cf to 5873274Compare
ContributorAuthor
isaacs commented Jun 15, 2023
The failing tests in CI are a bit confusing, these all pass locally, and it looks like they're not running with source maps enabled for some reason. I'm not sure why anything I did there would have changed that though. |
isaacsforce-pushed the isaacs/expose-source-maps-line-lengths branch from 5873274 to 11b3b96Compareisaacsforce-pushed the isaacs/expose-source-maps-line-lengths branch from 11b3b96 to da4b63aCompare
Uh oh!
There was an error while loading. Please reload this page.
isaacsforce-pushed the isaacs/expose-source-maps-line-lengths branch from da4b63a to 1485dc8Compare
doc/api/module.md Outdated
| - v12.17.0 | ||
| --> | ||
| #### `newSourceMap(payload)` |
Member
There was a problem hiding this comment.
The function signature should be updated to include the optional parameter too.
Suggested change
| #### `new SourceMap(payload)` | |
| #### `new SourceMap(payload[, lineLengths])` |
As the generated code line lengths property is not part of the source maps spec, would it be more prudent to set the property with an option bag instead of a positional parameter?
ContributorAuthor
There was a problem hiding this comment.
would it be more prudent to set the property with an option bag instead of a positional parameter?
No strong opinions here, but it's a pita to change this kind of thing later, so I'm feeling like it's probably a good idea, too. Anyone else wanna weight on it?
Member
There was a problem hiding this comment.
@bcoe would you mind taking a look at this PR? Thank you!
Document lineLengths argument Make lineLengths part of an option bag rather than a positional arg
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jul 12, 2023
Collaborator
nodejs-github-bot commented Jul 12, 2023
lpinca added commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 12, 2023
Landed in 9053943 |
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
Fix: #48460 PR-URL: #48461Fixes: #48460 Reviewed-By: Chengzhong Wu <[email protected]>
Merged
This was referenced Jul 16, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fix: nodejs#48460 PR-URL: nodejs#48461Fixes: nodejs#48460 Reviewed-By: Chengzhong Wu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fix: nodejs#48460 PR-URL: nodejs#48461Fixes: nodejs#48460 Reviewed-By: Chengzhong Wu <[email protected]>
Member
ruyadorno commented Sep 12, 2023
This commit does not land cleanly on |
targos added the semver-minor 
Member
targos commented Nov 15, 2023
This is another PR that should have been labeled semver-minor. |
nodejs-github-bot pushed a commit that referenced this pull request Feb 18, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Feb 18, 2025
PR-URL: nodejs#57098Fixes: nodejs#57094 Refs: nodejs#48461 Refs: nodejs#47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Feb 18, 2025
PR-URL: nodejs#57098Fixes: nodejs#57094 Refs: nodejs#48461 Refs: nodejs#47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Feb 18, 2025
PR-URL: nodejs#57098Fixes: nodejs#57094 Refs: nodejs#48461 Refs: nodejs#47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 20, 2025
PR-URL: #57098 Backport-PR-URL: #57129Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
PR-URL: nodejs#57098Fixes: nodejs#57094 Refs: nodejs#48461 Refs: nodejs#47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Feb 25, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 20, 2025
PR-URL: #57098 Backport-PR-URL: #57131Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request Apr 2, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request Apr 3, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
PR-URL: #57098Fixes: #57094 Refs: #48461 Refs: #47790 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #48460