build: fix building when there is only python3#48462
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jun 15, 2023
Review requested:
|
nodejs-github-bot added needs-ci 
lpinca approved these changes Jun 15, 2023
gengjiawen requested changes Jun 16, 2023
Member
gengjiawen left a comment
gengjiawen left a comment There was a problem hiding this comment.
This breaks all CI. I also have this changes on my macOS too.
Member
targos commented Jun 16, 2023
The error is: |
gengjiawen added the commit-queue-squash gengjiawen approved these changes Jun 17, 2023
github-actionsbot added request-ci-failed 
Contributor
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/5295843320 |
gengjiawen added request-ci github-actionsbot added request-ci-failed Contributor
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/5298312237 |
gengjiawen added request-ci github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 23, 2023
Collaborator
nodejs-github-bot commented Jun 23, 2023
Collaborator
nodejs-github-bot commented Jun 23, 2023
Collaborator
nodejs-github-bot commented Jun 23, 2023
Member
broken on windows arm64 cc @nodejs/platform-arm @StefanStojanovic 11:04:03 'C:\Python310\python_host.exe' is not recognized as an internal or external command,11:04:03 operable program or batch file.11:04:03 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'out\Release\\node_js2c_host.exe;src\inspector\node_protocol.pdl;src\inspector\node_protocol_config.json;deps\v8\include\js_protocol.pdl;out\Release\\obj\global_intermediate\concatenated_protocol.json;deps\openssl\openssl\util\libcrypto.num' exited with code 1. [C:\workspace\node-compile-windows\node\libnode.vcxproj]11:04:03 gen-regexp-special-case.cc11:04:03 C:\workspace\node-compile-windows\node\deps\v8\src\base\bits.h(448,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\gen-regexp-special-case_host.vcxproj]11:04:04 Creating library ..\..\out\Release\gen-regexp-special-case_host.lib and object ..\..\out\Release\gen-regexp-special-case_host.exp11:04:04 gen-regexp-special-case_host.vcxproj -> ..\..\out\Release\\gen-regexp-special-case_host.exe11:04:05 run_gen-regexp-special-case_action11:04:05 'C:\Python310\python_host.exe' is not recognized as an internal or external command,11:04:05 operable program or batch file.11:04:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for '..\..\out\Release\\gen-regexp-special-case_host.exe' exited with code 1. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\run_gen-regexp-special-case.vcxproj]11:04:05 run_gen-regexp-special-case_action11:04:05 'C:\Python310\python_host.exe' is not recognized as an internal or external command,11:04:05 operable program or batch file.11:04:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for '..\..\out\Release\\gen-regexp-special-case_host.exe' exited with code 1. [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\run_gen-regexp-special-case_host.vcxproj]11:04:05 11:04:05 > if errorlevel 1 (11:04:05 if not defined project_generated echo Building Node with reused solution failed. To regenerate project files use "vcbuild projgen" |
This was referenced Jun 24, 2023
| # Convert any paths to native form (first element is used directly). | ||
| # TODO(quote): regularize quoting path names throughout the module | ||
| command[1] ='"%s"'%command[1] | ||
| arguments= ['"%s"'%iforiinarguments] |
Member
There was a problem hiding this comment.
This should also upstream to https://github.com/nodejs/gyp-next
16 tasks
gengjiawen approved these changes Oct 25, 2023
gengjiawen added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Oct 25, 2023
Landed in d1ccca9 |
20 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
joshuafried pushed a commit to joshuafried/node that referenced this pull request Sep 13, 2024
PR-URL: nodejs/node#48462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Apr 27, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
PR-URL: #57970 Refs: #48462 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some environments, especially macOS, there is only
python3and nopython, replacing thepythonto<(python)can make gyp use the correct python.