Skip to content

net: improve network family autoselection handle handling#48464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 27, 2023
Merged

net: improve network family autoselection handle handling #48464

nodejs-github-bot merged 1 commit into from
Jun 27, 2023

Conversation

@ShogunPanda
Copy link
Contributor

@ShogunPandaShogunPanda commented Jun 15, 2023

This PR fixes network family autoselections in three area:

  1. Moves handle swapping before trying a new connection, as suggested in npm ERR! Exit handler never called! npm/cli#6409 (comment)
  2. Avoids spawning two different connection attempts, which could happen if a TLSSocket with a manually set backing Socket was used. See: PSA: If you're on node 20.0.0 and above, and want to use this library with client.configuration.connection.secure === true, use the argument --no-network-family-autoselection KararTY/dank-twitch-irc#13 (comment)
  3. Correctly handles AbortSignal when using network family auto selection.

Fixes: npm/cli#6409
Fixes: KararTY/dank-twitch-irc#13
Fixes: #47644

CC: @tniessen@silverwind

@ShogunPandaShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2023
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jun 15, 2023
This was referenced Jun 15, 2023
Closed
Closed
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52262/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52263/

mcollina
mcollina approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPandaShogunPanda mentioned this pull request Jun 19, 2023
Closed
@github-actionsgithub-actionsbot mentioned this pull request Jun 21, 2023
Open
29 tasks
@ShogunPandaShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 22, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 22, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52340/

@ShogunPanda
Copy link
ContributorAuthor

ShogunPanda commented Jun 24, 2023

I'll check the failing test locally this evening and then I'll update and finally merge this.

@ShogunPandaShogunPandaforce-pushed the network-selection-handle-improvements branch from 5388aa7 to 16ab933CompareJune 26, 2023 07:33
@ShogunPandaShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52487/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52499/

@github-actionsgithub-actionsbot mentioned this pull request Jun 27, 2023
Open
24 tasks
@ShogunPandaShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 27, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2023
@nodejs-github-botnodejs-github-bot merged commit fddd3ff into nodejs:mainJun 27, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2023

Landed in fddd3ff

@ShogunPandaShogunPanda deleted the network-selection-handle-improvements branch June 27, 2023 11:17
This was referenced Jun 28, 2023
Open
Open
Open
Open
@bnoordhuisbnoordhuis mentioned this pull request Jul 1, 2023
Closed
This was referenced Jul 2, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@ShogunPanda@RafaelGSS
net: improve network family autoselection handle handling
2c36397
PR-URL: #48464Fixes: npm/cli#6409Fixes: KararTY/dank-twitch-irc#13Fixes: #47644 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
hail2u added a commit to hail2u/hail2u.net that referenced this pull request Jul 16, 2023
@hail2u
Bookmarknodejs/node#48464
8625e85
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda@Ceres6
net: improve network family autoselection handle handling
9ffc304
PR-URL: nodejs#48464Fixes: npm/cli#6409Fixes: KararTY/dank-twitch-irc#13Fixes: nodejs#47644 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda@Ceres6
net: improve network family autoselection handle handling
f251e28
PR-URL: nodejs#48464Fixes: npm/cli#6409Fixes: KararTY/dank-twitch-irc#13Fixes: nodejs#47644 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
@ShogunPandaShogunPanda mentioned this pull request Aug 17, 2023
Closed
@ruyadorno
Copy link
Member

ruyadorno commented Sep 10, 2023

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

@lukekarryslukekarrys mentioned this pull request Sep 11, 2023
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@benjamingrbenjamingrbenjamingr approved these changes

@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

6 participants

@ShogunPanda@nodejs-github-bot@ruyadorno@mcollina@benjamingr@marco-ippolito