Skip to content

Conversation

@MoLow
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 16, 2023
@MoLow
Copy link
MemberAuthor

CC @nodejs/platform-ibmi

@abmusse
Copy link
Contributor

abmusse commented Jun 16, 2023

@MoLow

Thanks for pointing out that fs.watch is not supported on IBM i.

I've been trying to search on the repo and find technical reason why its unsupported by searching with:

https://github.com/nodejs/node/issues?q=fs.watch+ibmi

I haven't found much info on the reason its unsupported yet.

Is fs.watchFile also not supported?

The test case test-runner-watch-mode uses node --watch , Which API does that use (watch or watchFIle)?

@MoLow
Copy link
MemberAuthor

MoLow commented Jun 18, 2023

I've been trying to search on the repo and find technical reason why its unsupported by searching with:

I would assume that it is not implemented in libuv, but I was only able to find this #30819

The test case test-runner-watch-mode uses node --watch , Which API does that use (watch or watchFIle)?

it uses watch

constwatcher=watch(path,{ recursive,signal: this.#signal });

@abmusse
Copy link
Contributor

Thanks for the additional info!

I agree since its using watch API and that is unsupported on IBM i we should skip this test.

@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlaurichardlau added the ibm i Issues and PRs related to the IBM i platform. label Jun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-botnodejs-github-bot merged commit 0afd6e8 into nodejs:mainJun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0afd6e8

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48473 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48473 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48473 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #48473 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 10, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48473 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Richard Lau <[email protected]>
@MoLowMoLow deleted the fix-ibmi branch May 24, 2024 09:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibm iIssues and PRs related to the IBM i platform.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ibmi: parallel/test-runner-watch-mode fails with timeout

6 participants

@MoLow@nodejs-github-bot@abmusse@Linkgoron@lpinca@richardlau