Skip to content

Conversation

@bnoordhuis
Copy link
Member

Fix an oversight in the pull request that introduced the 'overlapped' option to the asynchronous child process methods, and also add it to the synchronous methods, like child_process.spawnSync().

Fixes: #48476
Refs: #29412

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jun 17, 2023
@bnoordhuisbnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 18, 2023
@github-actionsgithub-actionsbot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 18, 2023
@github-actions
Copy link
Contributor

Failed to start CI
- Validating Jenkins credentials ✘ Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/5305271123

@bnoordhuisbnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jun 19, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2023
@nodejs-github-bot
Copy link
Collaborator

Fix an oversight in the pull request that introduced the 'overlapped' option to the asynchronous child process methods, and also add it to the synchronous methods, like child_process.spawnSync(). Fixes: nodejs#48476 Refs: nodejs#29412
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

Related CI failures:

not ok 394 parallel/test-child-process-stdio-overlapped --- duration_ms: 235.92300 severity: fail exitcode: 1 stack: |- node:assert:408 throw err; ^ AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: assert.ok(error) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/test/parallel/test-child-process-stdio-overlapped.js:48:8) at Module._compile (node:internal/modules/cjs/loader:1434:14) at Module._extensions..js (node:internal/modules/cjs/loader:1518:10) at Module.load (node:internal/modules/cjs/loader:1249:32) at Module._load (node:internal/modules/cjs/loader:1065:12) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:158:12) at node:internal/main/run_main_module:30:49{generatedMessage: true, code: 'ERR_ASSERTION', actual: undefined, expected: true, operator: '==' } Node.js v23.0.0-pre 

@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@aduh95
Copy link
Contributor

This needs a rebase

@aduh95aduh95 added the needs-ci PRs that need a full CI run. label Nov 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.child_processIssues and PRs related to the child_process subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unreachable code reached when using{stdio: "overlapped"}

7 participants

@bnoordhuis@nodejs-github-bot@aduh95@jasnell@lpinca@anonrig@juanarbol