Skip to content

lib: remove duplicated requires in check_syntax#48508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jun 23, 2023
Merged

lib: remove duplicated requires in check_syntax #48508

nodejs-github-bot merged 1 commit into from
Jun 23, 2023

Conversation

@anonrig
Copy link
Member

@anonriganonrig commented Jun 21, 2023

Removes the duplicated require in url and internal/url as well as internal/options

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 21, 2023
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 21, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52323/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2023
@nodejs-github-botnodejs-github-bot merged commit 049052e into nodejs:mainJun 23, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 23, 2023

Landed in 049052e

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@anonrig@RafaelGSS
lib: remove duplicated requires in check_syntax
0da03f0
PR-URL: #48508 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig@Ceres6
lib: remove duplicated requires in check_syntax
e6c98a0
PR-URL: nodejs#48508 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig@Ceres6
lib: remove duplicated requires in check_syntax
888fcac
PR-URL: nodejs#48508 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno
Copy link
Member

ruyadorno commented Sep 10, 2023

This commit does not land cleanly on v18.x-staging and will need manual backport in case we want it in v18.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@anonrig@nodejs-github-bot@ruyadorno@lpinca@targos@juanarbol