typings: remove unused primordials#48509
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
targos approved these changes Jun 21, 2023
Member
targos left a comment
targos left a comment There was a problem hiding this comment.
I think it's ok to remove them because they are useless for the codebase, but the typings are correct. ArrayLength is a number, not a function:
anonrig added the author ready 
aduh95 previously requested changes Jun 22, 2023
Contributor
There was a problem hiding this comment.
I have a few issues with this PR:
- Can you fix the commit title so it says
unusedand notinvalid? There's nothing invalid about them, e.g.ArrayLengthis the primordial value ofArray.length, which is arguably not very useful, but certainly not invalid. - Should we also remove the other ones that we deem not useful? E.g.
ArrayName, the primordial value ofArray.nameis unlikely to ever be used in the codebase. Removing only.lengthfeels arbitrary. - There's a non-zero risk that someone with good intentions sees it's missing and make essentially a revert PR so the types are complete again, so could you replace them with comments explaining why they are not included?
aduh95 removed the author ready anonrig changed the title anonrig changed the title 
aduh95 dismissed their stale reviewStill not convinced by this change, but blocking concerns have been addressed.
aduh95 reviewed Jun 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
anonrig added the author ready 
lpinca approved these changes Jun 22, 2023
anonrig added the commit-queue 
nodejs-github-bot removed the commit-queue 
Collaborator
nodejs-github-bot commented Jun 23, 2023
Landed in 4d00da3 |
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48509 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48509 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48509 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #48509 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48509 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes unused and confusing primordials such as ArrayLength which corresponds to Array.length, and even though it is not used at all it is often get confused by Array.prototype.length.