test: remove unnecessary noop function args to musNotCall()

test/.eslintrc.yaml

@@ -47,7 +47,7 @@ rules:
 message: Use Number.isNaN() instead of the global isNaN() function.
  - selector: VariableDeclarator > CallExpression:matches([callee.name='debuglog'], [callee.property.name='debuglog']):not([arguments.0.value='test'])
 message: Use 'test' as debuglog value in tests.
- - selector: CallExpression:matches([callee.object.name="common"][callee.property.name=/^mustCall/],[callee.name="mustCall"],[callee.name="mustCallAtLeast"])>:first-child[type=/FunctionExpression$/][body.body.length=0]
+ - selector: CallExpression:matches([callee.object.name="common"][callee.property.name=/^must(Not)?Call/],[callee.name="mustCall"],[callee.name="mustCallAtLeast"],[callee.name="mustNotCall"])>:first-child[type=/FunctionExpression$/][body.body.length=0]
 message: Do not use an empty function, omit the parameter altogether.
  - selector: Identifier[name='webcrypto']
 message: Use `globalThis.crypto`.

test/parallel/test-child-process-execfile.js

@@ -84,7 +84,7 @@ const execOpts ={encoding: 'utf8', shell: true };
 // Verify that if something different than Abortcontroller.signal
 // is passed, ERR_INVALID_ARG_TYPE is thrown
 assert.throws(()=>{
-constcallback=common.mustNotCall(()=>{});
+constcallback=common.mustNotCall();
 
 execFile(process.execPath,[echoFixture,0],{signal: 'hello'},callback);
 },{code: 'ERR_INVALID_ARG_TYPE',name: 'TypeError'});

test/parallel/test-fs-promises-readfile.js

@@ -64,7 +64,7 @@ async function validateWrongSignalParam(){
 // is passed, ERR_INVALID_ARG_TYPE is thrown
 
 awaitassert.rejects(async()=>{
-constcallback=common.mustNotCall(()=>{});
+constcallback=common.mustNotCall();
 awaitreadFile(fn,{signal: 'hello'},callback);
 },{code: 'ERR_INVALID_ARG_TYPE',name: 'TypeError'});
 

test/parallel/test-fs-readfile.js

@@ -95,7 +95,7 @@ for (const e of fileInfo){
 // Verify that if something different than Abortcontroller.signal
 // is passed, ERR_INVALID_ARG_TYPE is thrown
 assert.throws(()=>{
-constcallback=common.mustNotCall(()=>{});
+constcallback=common.mustNotCall();
 fs.readFile(fileInfo[0].name,{signal: 'hello'},callback);
 },{code: 'ERR_INVALID_ARG_TYPE',name: 'TypeError'});
 }

test/parallel/test-http2-client-http1-server.js

@@ -11,7 +11,7 @@ const http2 = require('http2');
 const{ NghttpError }=require('internal/http2/util');
 
 // Creating an http1 server here...
-constserver=http.createServer(common.mustNotCall(()=>{}))
+constserver=http.createServer(common.mustNotCall())
 .on('clientError',common.mustCall((error,socket)=>{
 assert.strictEqual(error.code,'HPE_PAUSED_H2_UPGRADE');
 assert.strictEqual(error.bytesParsed,24);

test/parallel/test-https-agent-session-injection.js

@@ -32,7 +32,7 @@ const server = https.createServer(options, function(req, res){
 path: '/',
  ca,
 servername: 'nodejs.org',
-},common.mustNotCall(()=>{}));
+},common.mustNotCall());
 
 req.on('error',common.mustCall((err)=>{
 assert.strictEqual(
@@ -45,7 +45,7 @@ const server = https.createServer(options, function(req, res){
 path: '/',
  ca,
 servername: 'nodejs.org',
-},common.mustNotCall(()=>{}));
+},common.mustNotCall());
 
 second.on('error',common.mustCall((err)=>{
 server.close();

test/parallel/test-readline-interface.js

@@ -1067,8 +1067,7 @@ for (let i = 0; i < 12; i++){
 rli.question('foo?',common.mustCall((answer)=>{
 assert.strictEqual(answer,'baz');
 }));
-rli.question('bar?',common.mustNotCall(()=>{
-}));
+rli.question('bar?',common.mustNotCall());
 rli.write('baz\n');
 rli.close();
 }

test/parallel/test-stream-filter.js

@@ -169,7 +169,7 @@ const{setTimeout } = require('timers/promises');
 {
 conststream=Readable.from([1,2,3,4,5]);
 Object.defineProperty(stream,'map',{
-value: common.mustNotCall(()=>{}),
+value: common.mustNotCall(),
 });
 // Check that map isn't getting called.
 stream.filter(()=>true);

test/parallel/test-stream-flatMap.js

@@ -124,7 +124,7 @@ function oneTo5(){
 {
 conststream=oneTo5();
 Object.defineProperty(stream,'map',{
-value: common.mustNotCall(()=>{}),
+value: common.mustNotCall(),
 });
 // Check that map isn't getting called.
 stream.flatMap(()=>true);

test/parallel/test-stream-forEach.js

@@ -132,7 +132,7 @@ const{once } = require('events');
 {
 conststream=Readable.from([1,2,3,4,5]);
 Object.defineProperty(stream,'map',{
-value: common.mustNotCall(()=>{}),
+value: common.mustNotCall(),
 });
 // Check that map isn't getting called.
 stream.forEach(()=>true);

test/parallel/test-stream-readable-destroy.js

@@ -249,7 +249,7 @@ const assert = require('assert');
 
 {
 constread=newReadable({
-read: common.mustNotCall(function(){})
+read: common.mustNotCall()
 });
 read.destroy();
 assert.strictEqual(read.destroyed,true);

test/parallel/test-stream-readable-next-no-null.js

@@ -14,6 +14,6 @@ stream.on('error', expectsError({
 message: 'May not write null values to stream'
 }));
 
-stream.on('data',mustNotCall((chunk)=>{}));
+stream.on('data',mustNotCall());
 
 stream.on('end',mustNotCall());

test/parallel/test-stream-some-find-every.mjs

@@ -164,7 +164,7 @@ function oneTo5Async(){
 for(constopof['some','every','find']){
 conststream=oneTo5();
 Object.defineProperty(stream,'map',{
-value: common.mustNotCall(()=>{}),
+value: common.mustNotCall(),
 });
 // Check that map isn't getting called.
 stream[op](()=>{});

test/parallel/test-worker-data-url.js

@@ -5,17 +5,17 @@ const{Worker } = require('worker_threads');
 constassert=require('assert');
 
 newWorker(newURL('data:text/javascript,'))
-.on('error',common.mustNotCall(()=>{}));
+.on('error',common.mustNotCall());
 newWorker(newURL('data:text/javascript,export{}'))
-.on('error',common.mustNotCall(()=>{}));
+.on('error',common.mustNotCall());
 
 newWorker(newURL('data:text/plain,'))
 .on('error',common.mustCall());
 newWorker(newURL('data:text/javascript,module.exports={}'))
 .on('error',common.mustCall());
 
 newWorker(newURL('data:text/javascript,await Promise.resolve()'))
-.on('error',common.mustNotCall(()=>{}));
+.on('error',common.mustNotCall());
 newWorker(newURL('data:text/javascript,await Promise.reject()'))
 .on('error',common.mustCall());
 newWorker(newURL('data:text/javascript,await new Promise(()=>{})'))