build: fix configure --link-module#48522
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows.
Collaborator
nodejs-github-bot commented Jun 22, 2023
Review requested:
|
nodejs-github-bot added build 
richardlau added lts-watch-v16.x request-ci 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 22, 2023
Collaborator
nodejs-github-bot commented Jun 22, 2023
Collaborator
nodejs-github-bot commented Jun 22, 2023
Collaborator
nodejs-github-bot commented Jun 22, 2023
30 tasks
anonrig approved these changes Jun 23, 2023
richardlau added the author ready 
lpinca approved these changes Jun 23, 2023
richardlau added the commit-queue 25 tasks
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jun 24, 2023
Landed in ae9f919 |
25 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: #48522Fixes: #42302 Refs: #39069 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs#48522Fixes: nodejs#42302 Refs: nodejs#39069 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs#48522Fixes: nodejs#42302 Refs: nodejs#39069 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
ruyadorno commented Sep 10, 2023
This commit does not land cleanly on |
targos pushed a commit that referenced this pull request Oct 28, 2023
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: #48522Fixes: #42302 Refs: #39069 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs/node#48522Fixes: nodejs/node#42302 Refs: nodejs/node#39069 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Add the list of linked modules to the arguments for `js2c.py`. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows. PR-URL: nodejs/node#48522Fixes: nodejs/node#42302 Refs: nodejs/node#39069 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the list of linked modules to the arguments for
js2c.py. These were unintentionally omitted when the build was previously refactored to avoid command line length limits on Windows.Fixes: #42302
Refs: #39069