permission: handle end nodes with children cases#48531
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two paths overlaps, the permission model returns a false negative cause the Node* doesn't contain an empty child ("") to consider it as an end node. For instance, if you call
--allow-fs-read=/home/index.js,/home/index.jsonand call process.permission.has for both paths, it will return false for theindex.jssince it will create the following radix tree:and if you invert the parameters order:
--allow-fs-read=/home/index.json,/home/index.jsit will create an empty child for "/home/index.js" indicating "end node".To handle it I've included a new parameter to
Node*:is_leaf.