Skip to content

test: add Symbol.dispose support to mocktimers#48549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Jun 29, 2023
Merged

test: add Symbol.dispose support to mocktimers #48549

nodejs-github-bot merged 2 commits into from
Jun 29, 2023

Conversation

@benjamingr
Copy link
Member

@benjamingrbenjamingr commented Jun 25, 2023

Support Symbol.dispose in mock timers. Letting users of TS/Babel (and everyone else as soon as v8 ships) use using with the mock timers.

cc @ErickWendel @nodejs/test_runner

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 25, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 25, 2023
@benjamingrbenjamingrforce-pushed the add-dispose-mocktimers branch from ecb547c to 9ff2888CompareJune 25, 2023 18:12
aduh95
aduh95 reviewed Jun 25, 2023
View reviewed changes
@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52482/

ErickWendel
ErickWendel approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@ErickWendelErickWendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benjamingr
benjamingr commented Jun 26, 2023
View reviewed changes
@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 27, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52514/

This was referenced Jun 28, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52554/

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 29, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/48549 ✔ Done loading data for nodejs/node/pull/48549 ----------------------------------- PR info ------------------------------------ Title test: add Symbol.dispose support to mocktimers (#48549) Author Benjamin Gruenbaum (@benjamingr) Branch benjamingr:add-dispose-mocktimers -> nodejs:main Labels needs-ci, commit-queue-squash, test_runner Commits 2 - test: add Symbol.dispose support to mock timers - Update doc/api/test.md Committers 2 - Benjamin Gruenbaum - GitHub PR-URL: https://github.com/nodejs/node/pull/48549 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48549 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Antoine du Hamel Reviewed-By: Erick Wendel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update doc/api/test.md ℹ This PR was created on Sun, 25 Jun 2023 18:10:38 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497181144 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497192386 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/48549#pullrequestreview-1497609652 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/48549#pullrequestreview-1498055208 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-29T06:44:07Z: https://ci.nodejs.org/job/node-test-pull-request/52554/ - Querying data for job/node-test-pull-request/52554/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5409591686

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2023
@nodejs-github-botnodejs-github-bot merged commit 1683e60 into nodejs:mainJun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2023

Landed in 1683e60

@benjamingrbenjamingr deleted the add-dispose-mocktimers branch June 29, 2023 08:17
This was referenced Jun 30, 2023
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@benjamingr@RafaelGSS
test: add Symbol.dispose support to mock timers
a9756f3
PR-URL: #48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Merged
This was referenced Jul 4, 2023
Open
Open
@mrazauskasmrazauskas mentioned this pull request Jul 6, 2023
Closed
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@benjamingr@Ceres6
test: add Symbol.dispose support to mock timers
7e87b0d
PR-URL: nodejs#48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@benjamingr@Ceres6
test: add Symbol.dispose support to mock timers
2b8d918
PR-URL: nodejs#48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
@ruyadorno
Copy link
Member

ruyadorno commented Sep 11, 2023

This is blocked from landing on v18.x-staging pending backport of #47775

targos pushed a commit that referenced this pull request Nov 27, 2023
@benjamingr@targos
test: add Symbol.dispose support to mock timers
67925bb
PR-URL: #48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: add Symbol.dispose support to mock timers
e47a37d
PR-URL: nodejs/node#48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: add Symbol.dispose support to mock timers
c8c42f8
PR-URL: nodejs/node#48549 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Erick Wendel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

@cjihrigcjihrigcjihrig approved these changes

@ErickWendelErickWendelErickWendel approved these changes

@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benjamingr@nodejs-github-bot@ruyadorno@cjihrig@ErickWendel@MoLow@aduh95