Skip to content

Conversation

@shrujalshah28
Copy link
Contributor

@shrujalshah28shrujalshah28 commented Jun 27, 2023

Fixes: #48571

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jun 27, 2023
Co-authored-by: Moshe Atlow <[email protected]>
Co-authored-by: Benjamin Gruenbaum <[email protected]>
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 28, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48572 ✔ Done loading data for nodejs/node/pull/48572 ----------------------------------- PR info ------------------------------------ Title doc: update return type for describe (#48572) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch shrujalshah28:fix-#48571 -> nodejs:main Labels doc, author ready, test_runner Commits 4 - doc: update return type for describe - Update doc/api/test.md - Update doc/api/test.md - Update doc/api/test.md Committers 2 - Shrujal Shah - GitHub PR-URL: https://github.com/nodejs/node/pull/48572 Fixes: https://github.com/nodejs/node/issues/48571 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48572 Fixes: https://github.com/nodejs/node/issues/48571 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 27 Jun 2023 02:18:23 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48572#pullrequestreview-1501735652 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48572#pullrequestreview-1503058579 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48572 From https://github.com/nodejs/node * branch refs/pull/48572/merge -> FETCH_HEAD ✔ Fetched commits as baa5d8790f0e..901ece41efab -------------------------------------------------------------------------------- [main a2e8580341] doc: update return type for describe Author: Shrujal Shah Date: Tue Jun 27 02:15:23 2023 +0000 1 file changed, 1 insertion(+), 1 deletion(-) [main 2a499f6753] Update doc/api/test.md Author: Shrujal Shah Date: Tue Jun 27 10:30:19 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 22c8b07922] Update doc/api/test.md Author: Shrujal Shah Date: Tue Jun 27 14:08:14 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 744bd25df9] Update doc/api/test.md Author: Shrujal Shah Date: Wed Jun 28 10:35:24 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8) 

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update return type for describe

PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 77ee2c2f00] doc: update return type for describe
Author: Shrujal Shah [email protected]
Date: Tue Jun 27 02:15:23 2023 +0000
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/test.md

Co-authored-by: Moshe Atlow [email protected]
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD ce2f91b8f6] Update doc/api/test.md
Author: Shrujal Shah [email protected]
Date: Tue Jun 27 10:30:19 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/test.md

Co-authored-by: Shiba [email protected]
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 462a5c8904] Update doc/api/test.md
Author: Shrujal Shah [email protected]
Date: Tue Jun 27 14:08:14 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/test.md

Co-authored-by: Benjamin Gruenbaum [email protected]
PR-URL: #48572
Fixes: #48571
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]

[detached HEAD 53785c3bd3] Update doc/api/test.md
Author: Shrujal Shah [email protected]
Date: Wed Jun 28 10:35:24 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5407865808

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 29, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2023
@nodejs-github-botnodejs-github-bot merged commit fe4ac37 into nodejs:mainJun 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in fe4ac37

@shrujalshah28shrujalshah28 deleted the fix-#48571 branch June 29, 2023 08:35
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48572Fixes: #48571 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48572Fixes: nodejs#48571 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48572Fixes: nodejs#48571 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
PR-URL: #48572Fixes: #48571 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 11, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48572Fixes: #48571 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: wrong return type of describe

7 participants

@shrujalshah28@nodejs-github-bot@benjamingr@lpinca@MoLow@HinataKah0@aduh95