src: fix logically dead code reported by Coverity#48589
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Value of the `nwrite` variable will always be less than 0 when it reaches the `switch` statement because of the previous check, which causes `case 0` to never be executed, change the check to allow 0 or less.
nodejs-github-bot added c++ 
anonrig approved these changes Jun 28, 2023
lpinca approved these changes Jun 28, 2023
anonrig added author ready 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jun 28, 2023
33 tasks
Collaborator
nodejs-github-bot commented Jun 29, 2023
This was referenced Jun 30, 2023
JungMinu approved these changes Jul 3, 2023
RaisinTen approved these changes Jul 3, 2023
22 tasks
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 4, 2023
Landed in 586fcff |
This was referenced Jul 5, 2023
juanarbol added the dont-land-on-v20.x 
Member
juanarbol commented Jul 13, 2023
This depends on #47927 |
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Value of the `nwrite` variable will always be less than 0 when it reaches the `switch` statement because of the previous check, which causes `case 0` to never be executed, change the check to allow 0 or less. PR-URL: nodejs#48589 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Value of the `nwrite` variable will always be less than 0 when it reaches the `switch` statement because of the previous check, which causes `case 0` to never be executed, change the check to allow 0 or less. PR-URL: nodejs#48589 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value of the
nwritevariable will always be less than 0 when it reaches theswitchstatement because of the previous check, which causescase 0to never be executed, change the check to allow 0 or less.