build: do not pass target toolchain flags to host toolchain#48597
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64.
Collaborator
nodejs-github-bot commented Jun 29, 2023
Review requested:
|
nodejs-github-bot added build 
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jun 29, 2023
33 tasks
Collaborator
nodejs-github-bot commented Jun 30, 2023
richardlau approved these changes Jun 30, 2023
richardlau added the author ready This was referenced Jul 1, 2023
19 tasks
lpinca added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 12, 2023
Landed in 78e42e4 |
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: nodejs#48597 Reviewed-By: Richard Lau <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: nodejs#48597 Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 12, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64. PR-URL: #48597 Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes target toolchain arguments being passed to the host toolchain when cross-compiling. For example, -m64 is not available on aarch64.
See also NixOS/nixpkgs#238377 (comment)