doc: mention git node release prepare#48644
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jul 3, 2023
Review requested:
|
Member
targos commented Jul 3, 2023
I'd be more inclined to do it after the bugs outlined in nodejs/node-core-utils#686 are fixed. |
MemberAuthor
RafaelGSS commented Jul 3, 2023
Fair enough. I'll work on that too. |
MemberAuthor
RafaelGSS commented Jul 3, 2023
Blocked until nodejs/node-core-utils#686 resolution |
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSSforce-pushed the doc-mention-git-node-release branch from d2eefda to 6a24d2bCompareMemberAuthor
RafaelGSS commented Jul 4, 2023
Ready to go |
ruyadorno approved these changes Jul 5, 2023
targos approved these changes Jul 6, 2023
RafaelGSS added the commit-queue 
richardlau approved these changes Jul 6, 2023
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 6, 2023
Landed in bc8750e |
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48644 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#48644 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#48644 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48644 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48644 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48644 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @nodejs/releasers