Revert "test: remove test-crypto-keygen flaky designation"#48652
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added needs-ci This reverts commit 893c000. Refs: nodejs#48575 (comment)
richardlau approved these changes Jul 4, 2023
StefanStojanovic approved these changes Jul 4, 2023
lpinca added request-ci 
Contributor
Fast-track has been requested by @lpinca. Please 👍 to approve. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jul 4, 2023
Collaborator
nodejs-github-bot commented Jul 4, 2023
Collaborator
nodejs-github-bot commented Jul 4, 2023
KhafraDev approved these changes Jul 5, 2023
lpinca added the commit-queue nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Jul 5, 2023
Commit Queue failed- Loading data for nodejs/node/pull/48652 ✔ Done loading data for nodejs/node/pull/48652 ----------------------------------- PR info ------------------------------------ Title Revert "test: remove test-crypto-keygen flaky designation" (#48652) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:revert/893c000 -> nodejs:main Labels test, fast-track, needs-ci Commits 1 - Revert "test: remove test-crypto-keygen flaky designation" Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/48652 Reviewed-By: Richard Lau Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48652 Reviewed-By: Richard Lau Reviewed-By: Matthew Aitken -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Jul 2023 13:42:24 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48652#pullrequestreview-1512977268 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/48652#pullrequestreview-1514888857 ℹ This PR is being fast-tracked ✘ This PR needs to wait 21 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-07-04T19:25:03Z: https://ci.nodejs.org/job/node-test-pull-request/52604/ - Querying data for job/node-test-pull-request/52604/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5466566342 |
richardlau added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 5, 2023
Landed in 08638b7 |
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This reverts commit 893c000. Refs: nodejs#48575 (comment) PR-URL: nodejs#48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
This reverts commit 893c000. Refs: nodejs#48575 (comment) PR-URL: nodejs#48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
jkleinsc pushed a commit to electron/electron that referenced this pull request Sep 20, 2023
* chore: bump node in DEPS to v18.18.0 * child_process: harden against prototype pollution nodejs/node#48726 * deps: upgrade to libuv 1.46.0 nodejs/node#49591 * module: reduce url invocations in esm/load.js nodejs/node#48337 * Revert "test: remove test-crypto-keygen flaky designation" nodejs/node#48652 * fix: FTBTFS in ada dep ada-url/ada#464ada-url/idna#31 * fix: force_colors snapshot line number * chore: fixup patch indices * chore: update filenames.json --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
* chore: bump node in DEPS to v18.18.0 * child_process: harden against prototype pollution nodejs/node#48726 * deps: upgrade to libuv 1.46.0 nodejs/node#49591 * module: reduce url invocations in esm/load.js nodejs/node#48337 * Revert "test: remove test-crypto-keygen flaky designation" nodejs/node#48652 * fix: FTBTFS in ada dep ada-url/ada#464ada-url/idna#31 * fix: force_colors snapshot line number * chore: fixup patch indices * chore: update filenames.json --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 893c000.
Refs: #48575 (comment)