Skip to content

Conversation

@MoLow
Copy link
Member

@MoLowMoLow commented Jul 5, 2023

Follow-up for #47769 (comment)

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 5, 2023
@MoLow
Copy link
MemberAuthor

MoLow commented Jul 5, 2023

CC @anonrig

@MoLowMoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 5, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLowMoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 5, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2023
@nodejs-github-botnodejs-github-bot merged commit 6fda81d into nodejs:mainJul 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6fda81d

@MoLowMoLow deleted the navigator-partial branch July 5, 2023 13:13
@juanarbol
Copy link
Member

juanarbol commented Jul 13, 2023

This depends on a semver-major change, please do not land on v20.x (#47769)

@juanarboljuanarbol added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jul 13, 2023
@juanarboljuanarbol mentioned this pull request Jul 13, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48656 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48656 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.dont-land-on-v20.xPRs that should not land on the v20.x-staging branch and should not be released in v20.x.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@MoLow@nodejs-github-bot@juanarbol@anonrig@legendecas@ruyadorno