Skip to content

permission: add debug log when inserting fs nodes#48677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jul 13, 2023
Merged

permission: add debug log when inserting fs nodes #48677

nodejs-github-bot merged 1 commit into from
Jul 13, 2023

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSSRafaelGSS commented Jul 6, 2023

This will help when debugging issues in the filesystem Radix tree.

Output example:

$ NODE_DEBUG_NATIVE=PERMISSION_MODEL ./node --experimental-permission --allow-fs-read=/tmp/,/home/,/host -p '1 + 1'Inserting /tmp/* Prefix: Child(1): / Wildcard: /tmp/* End of tree - child(1)Inserting /home/* Prefix: Child(1): / Prefix: / Child(1): h Wildcard: home/* Child(2): t Wildcard: tmp/* End of tree - child(2) End of tree - child(1)Inserting /host Prefix: Child(1): / Prefix: / Child(1): h Prefix: ho Child(1): s Prefix: st End of tree: st Child(2): m Wildcard: me/* End of tree - child(2) Child(2): t Wildcard: tmp/* End of tree - child(2) End of tree - child(1)2(node:999070) ExperimentalWarning: Permission is an experimental feature(Use `node --trace-warnings ...` to show where the warning was created)

cc: @nodejs/security-wg

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 6, 2023

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Jul 6, 2023
@RafaelGSSRafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52647/

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 13, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 13, 2023
@nodejs-github-botnodejs-github-bot merged commit 8efdc7d into nodejs:mainJul 13, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 13, 2023

Landed in 8efdc7d

juanarbol pushed a commit that referenced this pull request Jul 13, 2023
@RafaelGSS@juanarbol
permission: add debug log when inserting fs nodes
82d6b13
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
@juanarboljuanarbol mentioned this pull request Jul 13, 2023
Merged
tniessen added a commit to tniessen/node that referenced this pull request Jul 14, 2023
@tniessen
permission: fix data types in PrintTree
024af08
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677
@tniessentniessen mentioned this pull request Jul 14, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jul 14, 2023
@tniessen
permission: fix data types in PrintTree
1d1a85b
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@tniessentniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS@Ceres6
permission: add debug log when inserting fs nodes
24bba8b
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#48677 Reviewed-By: Paolo Insogna <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@tniessen@Ceres6
permission: fix data types in PrintTree
6d53d0e
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677 PR-URL: nodejs#48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS@Ceres6
permission: add debug log when inserting fs nodes
05d58d2
Signed-off-by: RafaelGSS <[email protected]> PR-URL: nodejs#48677 Reviewed-By: Paolo Insogna <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@tniessen@Ceres6
permission: fix data types in PrintTree
1f69b61
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677 PR-URL: nodejs#48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@tniessen@UlisesGascon
permission: fix data types in PrintTree
0d48ac8
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: nodejs#48677 PR-URL: nodejs#48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@tniessen@RafaelGSS
permission: fix data types in PrintTree
30ea480
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 12, 2023
@RafaelGSS@ruyadorno
permission: add debug log when inserting fs nodes
8cab61c
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 12, 2023
@tniessen@ruyadorno
permission: fix data types in PrintTree
0eb0748
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@RafaelGSS@ruyadorno
permission: add debug log when inserting fs nodes
07eac0d
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@tniessen@ruyadorno
permission: fix data types in PrintTree
817b59c
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@ruyadornoruyadorno mentioned this pull request Sep 13, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@RafaelGSS@ruyadorno
permission: add debug log when inserting fs nodes
7aaecce
Signed-off-by: RafaelGSS <[email protected]> PR-URL: #48677 Reviewed-By: Paolo Insogna <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@tniessen@ruyadorno
permission: fix data types in PrintTree
804d880
* The first argument `node` should be a const pointer. * The second argument `spaces` should not be a signed integer type. * The local variable `child` should be size_t. * The local variable `pair` in the range declaration should be a reference type to avoid copying the object. Refs: #48677 PR-URL: #48770 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.debuggerIssues and PRs related to the debugger subsystem.needs-ciPRs that need a full CI run.permissionIssues and PRs related to the Permission Model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelGSS@nodejs-github-bot@ShogunPanda@tniessen