stream: fix deadlock when pipeing to full sink #48691
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jul 7, 2023
Review requested:
|
ronagforce-pushed the fix-pipe-deadlock branch 2 times, most recently from 07ade06 to f11c61fCompare
ronag commented Jul 7, 2023
Uh oh!
There was an error while loading. Please reload this page.
benjamingr approved these changes Jul 7, 2023
benjamingr approved these changes Jul 7, 2023
lpinca approved these changes Jul 7, 2023
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jul 8, 2023
Member
mcollina commented Jul 9, 2023
@ronag could you fix the commit message? |
This comment was marked as resolved.
This comment was marked as resolved.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jul 9, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jul 10, 2023
ronag added the commit-queue 
nodejs-github-bot removed the commit-queue nodejs-github-bot added the commit-queue-failed Collaborator
nodejs-github-bot commented Jul 10, 2023
Commit Queue failed- Loading data for nodejs/node/pull/48691 ✔ Done loading data for nodejs/node/pull/48691 ----------------------------------- PR info ------------------------------------ Title stream: fix deadlock when pipeing to full sink (#48691) Author Robert Nagy (@ronag) Branch ronag:fix-pipe-deadlock -> nodejs:main Labels stream, needs-ci Commits 1 - stream: fix deadlock when pipeing to full sink Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/48691 Refs: https://github.com/nodejs/node/issues/48666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48691 Refs: https://github.com/nodejs/node/issues/48666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: fix deadlock when pipeing to full sink ℹ This PR was created on Fri, 07 Jul 2023 12:08:43 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48691#pullrequestreview-1518738423 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48691#pullrequestreview-1518877825 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48691#pullrequestreview-1520765659 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-07-10T08:08:41Z: https://ci.nodejs.org/job/node-test-pull-request/52681/ - Querying data for job/node-test-pull-request/52681/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5512507137 |
Collaborator
nodejs-github-bot commented Jul 12, 2023
lpinca added commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 12, 2023
Landed in b34c5a2 |
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: #48666 PR-URL: #48691 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Contributor
Any plans to backport? Technically, the exact same patch should apply cleanly. |
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Contributor
kanongil commented Aug 25, 2023
Can we at least backport this to v18? |
kanongil pushed a commit to kanongil/node-1 that referenced this pull request Aug 25, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: nodejs#48666 PR-URL: nodejs#48691 Backport-PR-URL: nodejs#49323 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: #48666 PR-URL: #48691 Backport-PR-URL: #49323 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume. Refs: #48666 PR-URL: #48691 Backport-PR-URL: #49323 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When piping a paused Readable to a full Writable we didn't register a drain listener which cause the src to never resume.
Refs: #48666