dgram, net: support Symbol.asyncDispose

[atlowChemi]

No description provided.

[nodejs-github-bot]

Review requested:

• @nodejs/net

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52678/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/52701/

[MoLow]

@atlowChemi asked me where is the comment of the CI,
so here it is: https://ci.nodejs.org/job/node-test-pull-request/52701/

is seems like we passed the rate limit of the github api

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/48717 ✔ Done loading data for nodejs/node/pull/48717 ----------------------------------- PR info ------------------------------------ Title dgram, net: support `Symbol.asyncDispose` (#48717) Author Chemi Atlow (@atlowChemi) Branch atlowChemi:dgram-asyncDispose -> nodejs:main Labels dgram, net, author ready, needs-ci Commits 2 - dgram: socket add `asyncDispose` - net: server add `asyncDispose` Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/48717 Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48717 Reviewed-By: Matteo Collina Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Jul 2023 19:34:20 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48717#pullrequestreview-1520959501 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48717#pullrequestreview-1524942718 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48717#pullrequestreview-1524737638 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-07-11T18:34:30Z: https://ci.nodejs.org/job/node-test-pull-request/52701/ - Querying data for job/node-test-pull-request/52701/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48717 From https://github.com/nodejs/node * branch refs/pull/48717/merge -> FETCH_HEAD ✔ Fetched commits as ccdfb374383a..4792bdf0582d -------------------------------------------------------------------------------- [main 20437fb365] dgram: socket add `asyncDispose` Author: atlowChemi Date: Mon Jul 10 00:21:58 2023 +0300 3 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-dgram-async-dispose.mjs [main a31100b984] net: server add `asyncDispose` Author: atlowChemi Date: Mon Jul 10 00:22:05 2023 +0300 3 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-net-server-async-dispose.mjs ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) 
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 dgram: socket add asyncDispose
PR-URL: #48717
 Reviewed-By: Matteo Collina [email protected]
 Reviewed-By: Moshe Atlow [email protected]
 Reviewed-By: Benjamin Gruenbaum [email protected]
[detached HEAD 11447cd8e4] dgram: socket add asyncDispose
 Author: atlowChemi [email protected]
 Date: Mon Jul 10 00:21:58 2023 +0300
 3 files changed, 41 insertions(+), 1 deletion(-)
 create mode 100644 test/parallel/test-dgram-async-dispose.mjs
 Rebasing (3/4)
 Rebasing (4/4)
Executing: git node land --amend --yes
 --------------------------------- New Message ----------------------------------
 net: server add asyncDispose
PR-URL: #48717
 Reviewed-By: Matteo Collina [email protected]
 Reviewed-By: Moshe Atlow [email protected]
 Reviewed-By: Benjamin Gruenbaum [email protected]
[detached HEAD c1e9dc6ce0] net: server add asyncDispose
 Author: atlowChemi [email protected]
 Date: Mon Jul 10 00:22:05 2023 +0300
 3 files changed, 51 insertions(+), 1 deletion(-)
 create mode 100644 test/parallel/test-net-server-async-dispose.mjs
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5524812627

[nodejs-github-bot]

Landed in ccdfb37...0e9138d