Skip to content

fix: pr template CONTRIBUTING.md url#48719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 4 commits into from
Jul 17, 2023
Merged

fix: pr template CONTRIBUTING.md url #48719

nodejs-github-bot merged 4 commits into from
Jul 17, 2023

Conversation

@CGQAQ
Copy link
Contributor

@CGQAQCGQAQ commented Jul 10, 2023•
edited
Loading

When someone triple clicks to select the URL, they will result a 404 page because of the inclusion of the dot at the end

image
image

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 10, 2023
@CGQAQCGQAQ closed this Jul 10, 2023
@CGQAQCGQAQ deleted the fix-pr-template branch July 10, 2023 01:30
@CGQAQ
Copy link
ContributorAuthor

CGQAQ commented Jul 10, 2023

Just found there's a dot in the end

@CGQAQCGQAQ restored the fix-pr-template branch July 10, 2023 01:32
@CGQAQCGQAQ reopened this Jul 10, 2023
@CGQAQCGQAQforce-pushed the fix-pr-template branch 2 times, most recently from 1eb3cc9 to 041fcbeCompareJuly 10, 2023 01:35
aduh95
aduh95 reviewed Jul 15, 2023
View reviewed changes
aduh95
aduh95 reviewed Jul 15, 2023
View reviewed changes
CGQAQand others added 2 commits July 16, 2023 06:27
aduh95
aduh95 reviewed Jul 15, 2023
View reviewed changes
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 17, 2023
@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2023
@nodejs-github-botnodejs-github-bot merged commit 566bf5f into nodejs:mainJul 17, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 17, 2023

Landed in 566bf5f

pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@CGQAQ
doc: remove the . in the end to reduce confusing
2e53fd8
PR-URL: nodejs#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@CGQAQ
doc: remove the . in the end to reduce confusing
d396dd5
PR-URL: nodejs#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ@Ceres6
doc: remove the . in the end to reduce confusing
6807997
PR-URL: nodejs#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ@Ceres6
doc: remove the . in the end to reduce confusing
d91c621
PR-URL: nodejs#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@CGQAQ@UlisesGascon
doc: remove the . in the end to reduce confusing
da07907
PR-URL: nodejs#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@CGQAQ@RafaelGSS
doc: remove the . in the end to reduce confusing
fe20528
PR-URL: #48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
@UlisesGasconUlisesGascon mentioned this pull request Aug 15, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@CGQAQ@targos
doc: remove the . in the end to reduce confusing
dfd368a
PR-URL: #48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: remove the . in the end to reduce confusing
bbba0ef
PR-URL: nodejs/node#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: remove the . in the end to reduce confusing
14d8527
PR-URL: nodejs/node#48719 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

@debadree25debadree25debadree25 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CGQAQ@nodejs-github-bot@aduh95@debadree25