Skip to content

test: do not use test patterns in sharding tests#48768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rluvaton wants to merge 4 commits into from
Closed

test: do not use test patterns in sharding tests #48768

rluvaton wants to merge 4 commits into from

Conversation

@rluvaton
Copy link
Member

@rluvatonrluvaton commented Jul 14, 2023

Do not use test files glob patterns in test runner sharding tests so the sharding can be backported to version 20:

Cc @juanarbol, @MoLow

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 14, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 14, 2023
atlowChemi
atlowChemi reviewed Jul 14, 2023
View reviewed changes
atlowChemi
atlowChemi reviewed Jul 14, 2023
View reviewed changes
atlowChemi
atlowChemi reviewed Jul 14, 2023
View reviewed changes
@atlowChemiatlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2023
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52772/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 15, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52773/

@atlowChemiatlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 16, 2023
MoLow
MoLow requested changes Jul 16, 2023
View reviewed changes
Copy link
Member

@MoLowMoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really need this fix for the main branch so I'd prefer if we just create a backport PR with this fix applied on top of 9988130
this PR by itself won't make #48619 land clearly

@MoLowMoLow removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 16, 2023
@MoLowMoLow mentioned this pull request Jul 16, 2023
Closed
@rluvaton
Copy link
MemberAuthor

rluvaton commented Jul 16, 2023

Thanks!

@rluvatonrluvaton deleted the backport-shards-in-testing branch July 16, 2023 07:28
This was referenced Jul 16, 2023
Open
Open
This was referenced Jul 18, 2023
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLowMoLowMoLow requested changes

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@anonriganonriganonrig approved these changes

@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rluvaton@nodejs-github-bot@benjamingr@lpinca@anonrig@MoLow@atlowChemi