permission: fix recent coverity warning#48775
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
mhdawson commented Jul 14, 2023
mhdawson commented - address recent coverity warning by using auto &. Since the value is already const using a copy should not be necessary.
- address recent coverity warning by using auto &. Since the value is already const using a copy should not be necessary. Signed-off-by: Michael Dawson <[email protected]>
Collaborator
nodejs-github-bot commented Jul 14, 2023
Review requested:
|
nodejs-github-bot added c++ 
MemberAuthor
mhdawson commented Jul 14, 2023
This is the reported coverity warning: if (node->children.size()){93int child = 0; CID 322084 (#1 of 1): AUTO_CAUSES_COPY (AUTO_CAUSES_COPY) 1. auto_causes_copy: Using the auto keyword without an & causes the copy of an object of type pair. Use auto & instead of auto. 94for (constauto pair : node->children){Since pair is const, it seems to make sense to avoid a copy byusing auto & |
Member
RafaelGSS commented Jul 14, 2023
See: #48770 |
Signed-off-by: Michael Dawson <[email protected]>
MemberAuthor
mhdawson commented Jul 18, 2023
ok see its been covered. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.