src: remove ContextEmbedderIndex::kBindingDataStoreIndex#48836
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Jul 19, 2023
Review requested:
|
nodejs-github-bot added c++ 
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot.
joyeecheungforce-pushed the binding-data-slot branch from 7a026a6 to e1fbe62CompareCollaborator
nodejs-github-bot commented Jul 19, 2023
legendecas approved these changes Jul 19, 2023
Member
legendecas left a comment
legendecas left a comment There was a problem hiding this comment.
It seems that most call sites of Realm::GetBindingData(context) have a reference to the realm too. The static method can be replaced with an instance method instead in that case.
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jul 19, 2023
22 tasks
Collaborator
nodejs-github-bot commented Jul 20, 2023
This was referenced Jul 21, 2023
joyeecheung added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jul 26, 2023
Landed in faefe56 |
18 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: nodejs#48836 Reviewed-By: Chengzhong Wu <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: #48836 Reviewed-By: Chengzhong Wu <[email protected]>
Merged
nodejs-github-bot pushed a commit that referenced this pull request Aug 16, 2023
This version avoids the additional access to the embedder slot when we already have a reference to the realm. PR-URL: #49007 Refs: #48836 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Aug 16, 2023
This reduce the number of embedder slot accesses and also removes the assumption in a few binding methods that the current realm is the principal realm of the current environment (which is not true for shadow realms). PR-URL: #49007 Refs: #48836 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot. PR-URL: #48836 Reviewed-By: Chengzhong Wu <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
This version avoids the additional access to the embedder slot when we already have a reference to the realm. PR-URL: #49007 Refs: #48836 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
This reduce the number of embedder slot accesses and also removes the assumption in a few binding methods that the current realm is the principal realm of the current environment (which is not true for shadow realms). PR-URL: #49007 Refs: #48836 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now get the binding data through the reference to the realm directly, so remove it from the context embedder data slot.