fs: sync JSDoc with the actual implementation#48853
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JSDoc update was omitted during code implementation Refs: nodejs#46933
nodejs-github-bot added fs 
aduh95 approved these changes Jul 20, 2023
aduh95 added author ready 
anonrig reviewed Jul 21, 2023
| * } ReadableStream | ||
| * @param{{ | ||
| * type?: string; | ||
| * }} [options] |
ContributorAuthor
There was a problem hiding this comment.
It is same as the others I think
deokjinkim approved these changes Jul 23, 2023
deokjinkim added the commit-queue nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented Jul 23, 2023
Commit Queue failed- Loading data for nodejs/node/pull/48853 ✔ Done loading data for nodejs/node/pull/48853 ----------------------------------- PR info ------------------------------------ Title fs: sync JSDoc with the actual implementation (#48853) Author Hyunjin Kim (@illusi0n7, first-time contributor) Branch illusi0n7:dev/doc -> nodejs:main Labels fs, author ready, typings Commits 1 - fs: sync JSDoc with the actual implementation Committers 1 - Hyunjin Kim PR-URL: https://github.com/nodejs/node/pull/48853 Refs: https://github.com/nodejs/node/pull/46933 Reviewed-By: Antoine du Hamel Reviewed-By: Deokjin Kim ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48853 Refs: https://github.com/nodejs/node/pull/46933 Reviewed-By: Antoine du Hamel Reviewed-By: Deokjin Kim -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 20 Jul 2023 14:26:27 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/48853#pullrequestreview-1540155251 ✔ - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/48853#pullrequestreview-1542182649 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5634524749 |
Contributor
aduh95 commented Jul 23, 2023
Landed in 9c5e272, thanks for the contribution 🎉 |
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs#46933 PR-URL: nodejs#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs#46933 PR-URL: nodejs#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs#46933 PR-URL: nodejs#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs#46933 PR-URL: nodejs#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs#46933 PR-URL: nodejs#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs#46933 PR-URL: nodejs#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: #46933 PR-URL: #48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: #46933 PR-URL: #48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs/node#46933 PR-URL: nodejs/node#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
JSDoc comment did not match the actual implementation of `FileHandle#readableWebStream`. Refs: nodejs/node#46933 PR-URL: nodejs/node#48853 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSDoc update was omitted during code implementation
Refs: #46933